Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update PR template #312

Merged
merged 4 commits into from
Mar 28, 2023
Merged

docs: update PR template #312

merged 4 commits into from
Mar 28, 2023

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Mar 24, 2023 •
edited
Loading

Description

Update the PR template with:

  • more complete list of "types of change"
  • updated title standard to help with releases
  • headers all at level 1

Type of change:

  • docs: Documentation only changes

@hollandjg hollandjg marked this pull request as ready for review March 24, 2023 18:12
@hollandjg hollandjg requested a review from musslick as a code owner March 24, 2023 18:12
musslick
musslick approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

benwandrew
benwandrew approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

streamlined, nice!

@hollandjg hollandjg added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit 533924c Mar 28, 2023
@hollandjg hollandjg deleted the chore/update-pr-template branch March 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musslick musslick musslick approved these changes

@benwandrew benwandrew benwandrew approved these changes

@listar2000 listar2000 Awaiting requested review from listar2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hollandjg @musslick @benwandrew