Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import from tqdm.auto #314

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix: import from tqdm.auto #314

merged 1 commit into from
Mar 27, 2023

Conversation

benwandrew
Copy link
Collaborator

@benwandrew benwandrew commented Mar 27, 2023 •
edited
Loading

Description

Trying to fix the issue in PR #296

Type of change:

Delete as appropriate:

  • Bug fix

Features:

  • import from tqdm.auto instead of tqdm and reflecting change correspondingly in _progress_indicator

Questions:

  • not sure why this issue cropped up now, but is this the right fix? all tests are passing on my machine now...

@benwandrew benwandrew requested a review from musslick as a code owner March 27, 2023 16:14
@benwandrew benwandrew linked an issue Mar 27, 2023 that may be closed by this pull request
fix: resolve attribute error with tqdm import #313
Closed
@benwandrew benwandrew changed the base branch from main to dependabot/pip/torch-2.0.0 March 27, 2023 16:16
@benwandrew benwandrew requested review from hollandjg, gtdang and musslick and removed request for musslick March 27, 2023 16:17
gtdang
gtdang approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@gtdang gtdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update is cleaner and more efficient if you only need the auto.tqdm object. The previous way was importing the entire library then using one object within it.

What was the error that was occurring?

@gtdang
Copy link
Collaborator

gtdang commented Mar 27, 2023

Oh I see the linked PR and error. AttributeError: module 'tqdm' has no attribute 'auto'

Hm strange. I'm not sure what would cause that error but this new implementation is cleaner anyway.

@gtdang gtdang self-requested a review March 27, 2023 19:01
@benwandrew benwandrew merged commit 736422c into dependabot/pip/torch-2.0.0 Mar 27, 2023
@benwandrew benwandrew deleted the 313-fix-resolve-attribute-error-with-tqdm-import branch March 27, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtdang gtdang gtdang approved these changes

@hollandjg hollandjg Awaiting requested review from hollandjg

@musslick musslick Awaiting requested review from musslick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: resolve attribute error with tqdm import
2 participants
@benwandrew @gtdang