Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: attach images to notebooks #474

Merged
merged 13 commits into from
Jun 23, 2023
Merged

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Jun 21, 2023

Description

Include images in notebooks as "attachments" rather than using markdown linking. This makes notebooks completely self-contained.

Include documentation on how to do this.

Type of change

  • docs: Documentation only changes

@hollandjg hollandjg self-assigned this Jun 21, 2023
@hollandjg hollandjg changed the title Docs/attach images to notebooks docs: attach images to notebooks Jun 21, 2023
@hollandjg hollandjg marked this pull request as ready for review June 21, 2023 16:21
Copy link
Collaborator

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated naming of notebooks to conform to our style, and it looks like there are some conflicts to resolve, but otherwise good to go!

@hollandjg hollandjg added this pull request to the merge queue Jun 23, 2023
Merged via the queue into main with commit 8e49d84 Jun 23, 2023
@hollandjg hollandjg deleted the docs/attach-images-to-notebooks branch June 23, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figures in notebooks tutorials are not showing up properly
2 participants