fix Git download chart for GHE 2.11.0 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluehne
reviewed
Nov 20, 2017
updater/scripts/git-download.sh
Outdated
| @@ -15,13 +15,20 @@ function ghe_greater_equal () { | |||
|
|
|||
| if ghe_greater_equal "2.11.0" ; then | |||
| LOG_FILE="/var/log/github-audit.log" | |||
| # The "github-audit.log" log file introduced in GHE 2.11.0 is only rolled | |||
| # once a week. This was reported as bug and is likely fixed in an upcoming | |||
pluehne
reviewed
Nov 20, 2017
updater/scripts/git-download.sh
Outdated
| # once a week. This was reported as bug and is likely fixed in an upcoming | ||
| # version. In the meantime we grep for all log entries that have been | ||
| # written yesterday. | ||
| GREP_YESTERDAY="grep -F '$(date --date='yesterday' +'%b %d')'" |
There was a problem hiding this comment.
Maybe, we could add something like # TODO: remove workaround once GitHub Enterprise is patched so that we clean this up as soo as this workaround isn’t necessary anymore?
There was a problem hiding this comment.
Well, I don't think we can remove it because GHE 2.11.0 - 2.11.x will always have this bug.
pluehne
reviewed
Nov 20, 2017
The "github-audit.log" log file introduced in GHE 2.11.0 is only rolled once a week. This was reported as a bug and is likely fixed in an upcoming version. In the meantime we grep for all log entries that have been written yesterday.
larsxschneider
force-pushed
the
lars/download
branch
from
b8fbdcf to
f73391b
Compare
pluehne
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "github-audit.log" log file introduced in GHE 2.11.0 is only rolled
once a week. This was reported as bug and is likely fixed in an upcoming
version. In the meantime we grep for all log entries that have been
written yesterday.