HYDRA-951 : Add Maya command plugin to query build info #163
Conversation
| @@ -48,6 +49,7 @@ target_include_directories(${TARGET_NAME} | |||
| PRIVATE | |||
| $<$<BOOL:${UFE_FOUND}>:${UFE_INCLUDE_DIR}> | |||
| $<$<BOOL:${MayaUsd_FOUND}>:${MAYAUSD_INCLUDE_DIR}> | |||
| ${CMAKE_BINARY_DIR} | |||
There was a problem hiding this comment.
unintended inclusion. removed it.
| static void* creator() { return new MayaHydraPluginInfoCommand(); } | ||
| static MSyntax createSyntax(); | ||
|
|
||
| static const MString commandName; |
There was a problem hiding this comment.
where this member was used?
There was a problem hiding this comment.
did you mean to ask about commandName ?
There was a problem hiding this comment.
do we have a ticket to remove it from the mayaHydra command?
There was a problem hiding this comment.
Good catch. A file was missed to be added to this PR. Added now.
|
As per my comments elsewhere, if we have a new command to query mayaHydra information, we should remove it from the mayaHydra command: |
roopavr-adsk
changed the title
roopavr-adsk
dismissed stale reviews from ppt-adsk and lilike-adsk
via
e661515
There was a problem hiding this comment.
Why are we removing this? Seems like useful information.
There was a problem hiding this comment.
To print help of a mel command users are using help . So this was a bit redundant. This was also part of the description in the ticket.
There was a problem hiding this comment.
But help theCommand only lists the flags and their argument types. This is information about use. I would challenge that part of the ticket, and if it is really felt like it's a good idea, then move the information to a Markdown page in the repo. This doesn't address the manual maintenance objection, but I still think it's worth it. My preference would be to keep the -help flag.
There was a problem hiding this comment.
I am okay with leaving the help if it provides "how to use" information but I would like to avoid to list all the args as those need to be kept in sync with the args help. Maybe add something like:
For more information about supported arguments and their types use help
There was a problem hiding this comment.
Shall we move the detailed information to a Markdown file then? Maybe a new markdown file here: https://github.com/Autodesk/maya-hydra/tree/dev/doc
No description provided.