HYDRA-1267 - fix translation of coat parameters from standardsurface and openpbrsuface #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilike-adsk
commented
Oct 31, 2024
| const TfToken& _remappedBaseWeightName; | ||
| const TfToken& _remappedCoatColorName; | ||
| const TfToken& _remappedCoatWeightName; | ||
| }; | ||
|
|
||
| class MayaHydraOpenPBREmissionColorMaterialAttrConverter : public MayaHydraComputedMaterialAttrConverter |
There was a problem hiding this comment.
This will be eventually replaced by MayaHydraMixedColorMaterialAttrConverter when Maya has emissionWeight exposed via another PR.
ppt-adsk
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a more aligned visual result as VP2, using similar algorithm as MaterialX to translate coat parameters from Standard/OpenPBR Surface to UsdPreviewSurface
1.Like VP2, Coat color can contribute to Diffuse and Emissive Color now
2.Like VP2, Coat color can contribute to ClearCoat now
Also, refine the testStandardSurface/testOpenPBRSurface test case cover more params.