Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slug behaviour #575

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Fix slug behaviour #575

merged 3 commits into from
Mar 18, 2020

Conversation

cojennin
Copy link
Contributor

@cojennin cojennin commented Jan 9, 2020

Another take on fixing slug issues in #523

Added a bunch more tests, both around wp_insert_post and the Rest API to give a bit more confidence to this PR.

To Test

The following should all be captured in the automated tests, but for manually testing:

Do this for posts and pages

In Classic Editor & In Block Editor

  1. Create a post, save it as a custom status
  2. Update the post title
  3. Confirm the post slug has been updated

In Classic Editor & In Block Editor

  1. Create a post, save it as a custom status
  2. Set the post slug and save the post
  3. Update the post title and save the post
  4. Confirm the slug has not changed

In Classic Editor & In Block Editor

  1. Create a page, save it as a custom status
  2. Update the page title
  3. Confirm the page slug has been updated

*Repeat this but make the page a child page

In Classic Editor & In Block Editor

  1. Create a page, save it as a custom status
  2. Set the page slug and save the post
  3. Update the page title and save the post
  4. Confirm the slug has not changed

*Repeat this but make the page a child page

@cojennin cojennin requested review from mjangda and dchymko January 9, 2020 16:16
@cojennin cojennin force-pushed the fix/post-slug-editable-v2 branch 5 times, most recently from 0510458 to d978b29 Compare January 10, 2020 17:41
@cojennin cojennin force-pushed the fix/post-slug-editable-v2 branch 3 times, most recently from 21a2c0d to 867693a Compare January 28, 2020 21:07
@cojennin cojennin force-pushed the fix/post-slug-editable-v2 branch 2 times, most recently from 7b070cf to 4bfdd1b Compare January 30, 2020 03:20
@cojennin cojennin requested a review from WPprodigy January 30, 2020 03:20
@cojennin cojennin force-pushed the fix/post-slug-editable-v2 branch 2 times, most recently from 824a8b2 to 2654ecb Compare January 30, 2020 03:31
@cojennin cojennin force-pushed the fix/post-slug-editable-v2 branch from 2654ecb to 419d1fa Compare February 11, 2020 16:45
@cojennin cojennin added this to the 0.9.5 milestone Feb 20, 2020
@cojennin
Copy link
Contributor Author

This PR is already being used by other folks, so if no one has anything they want to flag I'll merge as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant