Remove legacy asset enqueueing compatibility code

[jom]

See: #1354

Remove constant check and compatibility filters that maintain the old enqueueing strategy:

WP-Job-Manager/wp-job-manager.php

Lines 230 to 261 in b0a781a

	/**
	* Starting in WP Job Manager 1.32.0, the chosen JS library and core frontend WPJM CSS will only be enqueued
	* when used on a particular page. Theme and plugin authors as well as people who have overloaded WPJM's default
	* template files should test this upcoming behavior.
	*
	* To test this behavior before 1.32.0, add this to your `wp-config.php`:
	* define( 'JOB_MANAGER_TEST_NEW_ASSET_BEHAVIOR', true );
	*
	* Unless this constant is defined, WP Job Manager will default to its old behavior: chosen JS library and
	* frontend styles are always enqueued.
	*
	* If your theme or plugin depend on the `frontend.css` or chosen JS library from WPJM core, you can use the
	* `job_manager_chosen_enabled` and `job_manager_enqueue_frontend_style` filters.
	*
	* Example code for a custom shortcode that depends on the chosen library:
	*
	* add_filter( 'job_manager_chosen_enabled', function( $chosen_used_on_page ) {
	* global $post;
	* if ( is_singular()
	* && is_a( $post, 'WP_Post' )
	* && has_shortcode( $post->post_content, 'resumes' )
	* ) {
	* $chosen_used_on_page = true;
	* }
	* return $chosen_used_on_page;
	* } );
	*
	*/
	if ( ! defined( 'JOB_MANAGER_TEST_NEW_ASSET_BEHAVIOR' ) || true !== JOB_MANAGER_TEST_NEW_ASSET_BEHAVIOR ) {
	add_filter( 'job_manager_chosen_enabled', '__return_true' );
	add_filter( 'job_manager_enqueue_frontend_style', '__return_true' );
	}

[tripflex]

Any specific reason for not keeping the asset registered and just dealing with the enqueueing of the asset?

[jom]

@tripflex Are you referring to chosen and the original PR that this references?

We could, but it has a bit of a cascading effect unless we update templates/form-fields/term-multiselect-field.php and templates/form-fields/multiselect-field.php. Those blindly enqueue wp-job-manager-multiselect which has no effect if that is never registered (which is good if we have disabled the library). We could, technically, register chosen JS and CSS and leave them out there, but if we are replacing that library soon I'd rather not make it easier for people to add dependencies other than wp-job-manager-multiselect.