Release 1.32.0

[jom]

Release for 1.32.0

Closed Issues | PRs | Diff

Timeline

• Target Release: 2019-01-15 2019-01-23
• Beta 2: 2019-01-18 Beta 2 Release | Download
• Beta 1: 2018-12-17 Beta 1 Release | Download

Things to Test

• Theme compatibility on [jobs] shortcode with category select fields. Try with multiple category select option enabled and disabled.
• Theme compatibility with frontend styles. As deprecated in an earlier release, frontend styles must be told when to be enqueued using job_manager_enqueue_frontend_style filter. See this code.
• Permalink settings persist when moving an existing instance to 1.32.0.
• Author selection works when editing a job listing in WP admin.
• See changelog for additional things to look at.

Comment on this PR with any issues that are found.

Changelog:

= 1.32.0 =
* Enhancement: Switched from Chosen to Select2 for enhanced dropdown handling and better mobile support. May require theme update.
* Enhancement: Draft and unsubmitted job listings now appear in `[job_dashboard]`, allowing users to complete their submission.
* Enhancement: Filled and expired positions are now hidden from WordPress search. (@felipeelia)
* Enhancement: Adds additional support for the new block editor. Restricted to classic block for compatibility with frontend editor.
* Enhancement: Job types can be preselected in `[jobs]` shortcode with `?search_job_type=term-slug`. (@felipeelia)
* Enhancement: Author selection in WP admin now uses a searchable dropdown.
* Enhancement: Setup wizard is accessed with a flash message instead of an automatic redirect upon activation.
* Enhancement: When using supported themes, job listing archive slug can be changed in Permalink settings.
* Fix: Company tagline alignment issue with company name. (@0xDELS)
* Fix: "Load Previous Listings" link unnecessarily shows up on `[jobs]` shortcode. (@tonytettinger)
* Fix: Category selector fixed in the job listings page in WP Admin. (@AmandaJBell)
* Fix: Issue with quote encoding on Apply for Job email link.
* Fix: Link `target` attributes have been removed in templates.
* Dev: Allow for job submission flow to be interrupted using `before` argument on form steps.
* Dev: HTML allowed in custom company field labels. (@tripflex)
* Dev: Job feed slug name can be customized with the `job_manager_job_feed_name` filter.
* Deprecated: Unreleased REST API implementation using `WPJM_REST_API_ENABLED` was replaced with standard WP REST API.

[vetpetjobs]

Enhancement to new Draft Job Ad feature (sorry if this is the wrong place to post this)

Steps to Reproduce

1 - Given the proposed new ability to retain draft Job Ads
2 - Create a special "View Only" link so that Managers/Clients can View an Unpublished Draft Job Ad (not logged in to WP)
3 - Allow copy and paste link into external email client or simple "Send this link to"
4 - No need for any complex approval process, merely to allow third parties (not logged in to WP) to preview a Job Ad prior to publishing
5 - Non indexable by Search Engines

What I Expected
N/a
What Happened Instead
N/a
WordPress / WP Job Manager Version
5.01+/WP 1.32.0-beta1
Browser / OS Version
All
Screenshot / Video

N/a - haven't seen new Draft Job Ad styling
Context / Source

We are multi-users of WP Job Manager

[alexsanford]

The width of the Category input on the Jobs page does not appear to resizing with the parent container.

GIF: http://cld.wthms.co/SiNXRa

This happens for both the multiselect and single-select versions of the input. It does not appear to be theme-dependent (I'm seeing it happen on Twenty Nineteen, Twenty Seventeen, and Divi).

[alexsanford]

On Jobify, upgrading to 1.32.0 causes the Category select box to render as a normal HTML multiselect. It does not use Chosen OR Select2.

http://cld.wthms.co/CKthrh

Note that this happens on the /jobs page, which is the archive page. For a normal page using the shortcode, I do not see this behaviour.

[alexsanford]

On Listify, the "Post a Job" page is showing two renders of the Category selection dropdown, one with Select2 and one with Chosen.

It's worth noting that the "Submit Resume" page does not have the same problem. It uses only Select2 for the dropdown. I'm using the current master branch of Resumes, which is the 1.17.1 beta.

http://cld.wthms.co/SjyMRW

[alexsanford]

When posting a job on Listable, I'm seeing a horizontal scrollbar on the Select2 UI for the Category select.

http://cld.wthms.co/Pj40Kc

I'm also seeing this on the Category select on the Resumes page and the Submit Resume page.

[alexsanford]

On the Specialty theme, upgrading to 1.32.0 causes the Category select box to render as a normal HTML multiselect. It does not use Chosen OR Select2.

http://cld.wthms.co/BTv2rU

Note that this happens on the /jobs page, which is the archive page. For a normal page using the shortcode, I do not see this behaviour.

[jom]

On Listify, the "Post a Job" page is showing two renders of the Category selection dropdown, one with Select2 and one with Chosen.

Fixed in #1657, although a similar check should also be done in Listify eventually.

When posting a job on Listable, I'm seeing a horizontal scrollbar on the Select2 UI for the Category select.

After updating to 1.9.4, it seems to not be there. Listable also seems to package and use select2 separately, which they may no longer need to do. cc: @pixelgrade

On Jobify, upgrading to 1.32.0 causes the Category select box to render as a normal HTML multiselect. It does not use Chosen OR Select2.

I think this will need to be handled in Jobify. With do_shortcode() (which is what is used on their archive page), themes will need to manually tell WPJM that these assets should be loaded.

cc: @spencerfinnell

On the Specialty theme, upgrading to 1.32.0 causes the Category select box to render as a normal HTML multiselect. It does not use Chosen OR Select2.

At least with the version we have (1.0), it looks like the archive page produces a similar view to the [jobs] page. The assets would need to be included by telling WPJM via the job_manager_enhanced_select_enabled filter that they are needed on that page.

cc: @tsiger

For these last two issues, we could [temporarily] include these assets on the jobs archive page as well. It might save some headache while themes upgrade. @tsiger @spencerfinnell @alexsanford, thoughts?

[spencerfinnell]

@jom I would agree to enable the assets on archives (jobs and resumes). It seems like a regression because Chosen didn't require any extra code to enqueue before right?

For now I've added

		add_filter( 'has_wpjm_shortcode', function( $has ) {
			if ( is_post_type_archive( 'job_listing' ) ) {
				return true;
			}

			return $has;
		} );

And similar for Resumes.

P.S https://github.com/Astoundify/jobify/tree/release/3.11.0 includes style updates and these fixes.

---

Edit: Actually I guess it's not a regression in the plugin since on a default theme the archive doesn't display the filters by default.

[jom]

@spencerfinnell It was actually going to be required to do that in themes/plugins in this version anyway (#1358) so we didn't load these assets everywhere, but we changed the filters used to make it compatible in this version so I wouldn't expect themes to have added that already. Out of curiosity, for Listify and Jobify, you have a sense of how many folks are updating the [parent] theme regularly? I'm inclined to add the check for is_post_type_archive( 'job_listing' ). It is still a lot better than enqueuing the assets everywhere 😄.

[anastis]

Hi, co-author of Specialty, colleague of @tsiger here.
Specialty will probably need an update no matter what, as it utilizes Chosen in a custom page template and both the job_listing_category and job_listing_type taxonomy archives, in addition to the post type archive and the shortcode pages mentioned above.

Until we change it to work with select2, this should maintain compatibility with the new version:

	add_filter( 'job_manager_chosen_enabled', 'ci_theme_wpjm_maybe_enqueue_chosen' );
	function ci_theme_wpjm_maybe_enqueue_chosen() {
		if ( is_post_type_archive( 'job_listing' ) ||
		     is_tax( array( 'job_listing_category', 'job_listing_type' ) ) ||
		     is_page_template( array( 'template-listing-jobs.php' ) )
		) {
			return true;
		}

		return false;
	}

However, it doesn't quite work. Not sure if it's a bug or a design decision, but this bit has been removed, making the (theme's) initialization of chosen, fail:

wp_localize_script(
	'chosen', 'job_manager_chosen_multiselect_args',
	apply_filters(
		'job_manager_chosen_multiselect_args', array(
			'search_contains' => true,
		)
	)
);

@jom happy to share the latest version of the theme with you. Let me know how/where.

[jom]

@anastis The localization was taken out because we don't use it in core, but I've added it back in on #1659 (during the deprecation phase) if others are referencing that.

I've also set it to load select2 (not chosen) on taxonomy and archive pages in #1659. This won't fix the issue on Specialty for the drop down using a standard drop down.

[jom]

I'm pushing the final release until next week (2019-01-22). Beta 2 should be out tomorrow (2019-01-15).

[jom]

Beta 2 released. Final release scheduled for 2019-01-23 (next Wednesday).