Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional arg to job dashboard action hook to provide more context #1386

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Add additional arg to job dashboard action hook to provide more context #1386

merged 1 commit into from
Apr 12, 2018

Conversation

jonasvogel
Copy link
Contributor

For custom job dashboard action handlers, the $job_id was missing as argument to provide more context (e.g. what job was changed with this action).

Changes proposed in this Pull Request:

  • Added additional arg to action hook to job_manager_job_dashboard_do_action_' . $action

jom
jom approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jom jom merged commit 701f372 into Automattic:master Apr 12, 2018
@jom jom added this to the 1.31.0 milestone Apr 12, 2018
@jom jom mentioned this pull request Apr 18, 2018
Merged
@jonasvogel jonasvogel deleted the job_dashboard_do_action branch May 3, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasvogel @jom