Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue the datepicker UI when using a date field in the front-end #1390

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

jom
Copy link
Member

@jom jom commented Mar 20, 2018

Changes proposed in this Pull Request:

  • Enqueue the jQuery UI CSS when using the datepicker on the front-end.

Testing instructions:

  • Add a datepicker field and verify it is styled correctly on the front-end.
add_filter( 'submit_job_form_fields', function( $fields ) {
	$fields['job']['fancy_date'] = array(
		'label'       => __( 'Fanciest of Dates', 'wp-job-manager' ),
		'type'        => 'date',
		'required'    => false,
		'priority'    => 5
	);
	return $fields;
} );

Builds off of #1353

@jom jom added the [Type] Bug label Mar 20, 2018
@jom jom added this to the 1.30.2 milestone Mar 20, 2018
@jom jom force-pushed the fix/datepicker-frontend-style branch from 2b94718 to e624505 Compare March 20, 2018 12:38
@jom jom modified the milestones: 1.30.2, 1.31.0 Mar 20, 2018
@jom jom requested a review from alexsanford March 21, 2018 15:56
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I guess Application Deadline must do this itself? There doesn't seem to be any style issues with that date field (thus why I missed this issue). Maybe we should consider removing that styling from Application Deadline in favour of this solution?

(Also I edited the description to link to the correct PR 😄 )

@jom jom force-pushed the fix/datepicker-frontend-style branch 5 times, most recently from d8421b3 to a398148 Compare March 21, 2018 21:40
@jom jom force-pushed the fix/datepicker-frontend-style branch from a398148 to 890ed0b Compare March 21, 2018 22:31
@jom jom merged commit 72ee9bc into master Apr 11, 2018
@jom jom deleted the fix/datepicker-frontend-style branch April 11, 2018 15:18
@jom jom mentioned this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants