Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/data deletion pages #1421

Merged
merged 2 commits into from
Apr 6, 2018
Merged

Add/data deletion pages #1421

merged 2 commits into from
Apr 6, 2018

Conversation

alexsanford
Copy link
Contributor

Contributes to #1362

This PR deletes all pages associated with WPJM: the Submit Job page, the Job Dashboard page, and the Job Listings page.

Note: this builds upon #1418 and so the first commit (which is shared) should be ignored. After #1418 is merged, this will be rebased.

Testing

  • First, you may want to back up your data, or copy it to a fresh WordPress installation.

  • Ensure that the tests pass.

  • Ensure that WPJM has set up the pages above. (You also may want to test it without some of the pages set up, to ensure that it behaves as expected).

  • Delete the WP Job Manager plugin.

  • Look at the Pages. Ensure that the pages listed above have been Trashed, and the other pages have not.

  • Please also test on a multisite installation. When the plugin is deleted from the Network Admin, the data should be deleted across all sites.

@alexsanford alexsanford self-assigned this Apr 4, 2018
@alexsanford alexsanford requested review from jom and donnapep April 4, 2018 19:14
@jom jom added this to the 1.31.0 milestone Apr 6, 2018
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, too, looks like a nice PR. 🌮

@alexsanford alexsanford force-pushed the add/data-deletion-pages branch from cb04c3e to 9c97ae2 Compare April 6, 2018 17:47
@alexsanford alexsanford merged commit 69dfbd7 into master Apr 6, 2018
@alexsanford alexsanford deleted the add/data-deletion-pages branch April 6, 2018 17:57
@jom jom mentioned this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants