Add data deletion for WPJM transients #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsanford
force-pushed
the
add/data-deletion-transients
branch
from
f40d547 to
c862e32
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1362
This PR, on plugin deletion, deletes the transients associated with WPJM from the database. The following transients (as regular expressions) should be deleted:
_job_manager_activation_redirectget_job_listings-transient-versionjm_.*Testing
First, you may want to back up your data, or copy it to a fresh WordPress installation.
Ensure that the tests pass.
Add some of the above transients to the database.
Delete the WPJM plugin.
Inspect the database to ensure that those transients have been deleted. You can use this query to see all the transients in the DB:
SELECT option_id, option_name from wp_options WHERE option_name LIKE "_transient_%". You can also use a plugin like "Transients Manager" to check them.Ensure that the transient itself and it's timeout value have been deleted (e.g. both
_transient__job_manager_activation_redirectand_transient_timeout__job_manager_activation_redirect).Please also test on a multisite installation. When the plugin is deleted from the Network Admin, the transients should be deleted across all sites.