Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to the job title and replace H1 tag with H2 #1433

Merged
merged 2 commits into from
Apr 12, 2018

Conversation

abdullah1908
Copy link
Contributor

@abdullah1908 abdullah1908 commented Apr 10, 2018

Fixes #1424

Changes proposed in this Pull Request:

  • Added class to the job title

  • Replaced H1 tag with H2

@jom jom added this to the 1.31.0 milestone Apr 10, 2018
@jom
Copy link
Member

jom commented Apr 10, 2018

Hi @abdullah1908! Thanks for sending this in. We'll ship it with 1.31.0. Would you mind changing the version for the template (at the top of the file) to 1.31.0? Thank you!

@spencerfinnell
Copy link
Contributor

spencerfinnell commented Apr 11, 2018

@jom is there an expected release date for 1.31.0? Since the only way to target this before was the h1 tag directly and this is now removed themes will need to adjust accordingly.

@jom
Copy link
Member

jom commented Apr 11, 2018

@spencerfinnell We're trying to get a beta out by next Wednesday (18th) for release (hopefully) sometime the following week.

@richardmtl
Copy link

@spencerfinnell Yeah, I did raise that concern in the original issue:

If any themes are already styling this, they'll have to update their styles which could be a "breaking" change on some sites.

I haven't seen this used much "in the wild" though, in the sites that I've done support for. I think this PR makes things better all-around for the plugin; do you think it'll be a big deal?

@spencerfinnell
Copy link
Contributor

@jom Thanks.

@richardmtl Honestly not sure how many people use this shortcode. But an h2 tag will still likely have some styling inside a page so it will at least still look like a title. Hopefully it will take a similar shape to what anyone previous needed to override it to. We don't have any specific styles for this in our themes.

@abdullah1908
Copy link
Contributor Author

abdullah1908 commented Apr 11, 2018

@jom @richardmtl ,

I have updated the template version as well 💯

Let me know if anything for me relevant to this PR.

Thanks

@jom jom merged commit 2c6b91e into Automattic:master Apr 12, 2018
@jom jom mentioned this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants