Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-fill widget instance array with defaults #1445

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Pre-fill widget instance array with defaults #1445

merged 1 commit into from
Apr 13, 2018

Conversation

jom
Copy link
Member

@jom jom commented Apr 13, 2018

Fixes #1444

Changes proposed in this Pull Request:

  • For widget instances, merge the passed instance array with the defaults for the widget.

Testing instructions:

  • Ensure define( 'WP_DEBUG', true ); and define( 'WP_DEBUG_LOG', true ); are in your wp-config.php.
  • Create both featured and non-featured listings.
  • Add both WPJM widgets from the Customizer but don't save any values.
  • Load a page with those widgets.
  • Verify no errors from the widget files are entered into debug.log.

Proposed changelog entry for your changes:

  • Fix: Issue with errors appearing when widgets were added from Customizer.

@jom jom added the [Type] Bug label Apr 13, 2018
@jom jom added this to the 1.31.0 milestone Apr 13, 2018
@jom jom merged commit 0353fb5 into master Apr 13, 2018
@jom jom deleted the fix/widget-instance-default-errors#1444 branch April 13, 2018 14:34
@jom jom mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Type] Bug
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jom