Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for filtering job listings on Filled and Featured in WP Admin #1447

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Add functionality for filtering job listings on Filled and Featured in WP Admin #1447

merged 2 commits into from
Apr 17, 2018

Conversation

alexsanford
Copy link
Contributor

Fixes #980

Changes proposed in this Pull Request:

  • Adds filter dropdowns to the Job Listings page in WP Admin for Filled and Featured jobs.

Testing instructions:

  • Go to the Job Listings page in WP Admin.
  • Choose values from the new dropdowns at the top of the table. Their initial values will be "Select Filled" and "Select Featured".
  • Press "Filter".
  • When the page reloads, the visible job listings should be filtered based on the values of the dropdowns.
  • The dropdowns should retain their selected values.

Proposed changelog entry for your changes:

  • Add filters in WP Admin for Filled and Featured jobs.

@alexsanford alexsanford self-assigned this Apr 13, 2018
@alexsanford alexsanford requested review from jom and donnapep April 13, 2018 17:25
jom
jom requested changes Apr 16, 2018
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well for me. Code looks good, just needs string i11n and then 🚢.

includes/admin/class-wp-job-manager-cpt.php Outdated
$this->jobs_filter_dropdown( 'job_listing_filled', array(
array(
'value' => '',
'text' => 'Select Filled',
Copy link
Member

@jom jom Apr 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings need i11n.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed.

@jom jom force-pushed the add/filtering-for-job-meta branch from 74821c1 to 7ff287c Compare April 16, 2018 12:08
@jom jom added this to the 1.31.0 milestone Apr 17, 2018
@alexsanford alexsanford merged commit 33a9858 into master Apr 17, 2018
@alexsanford alexsanford deleted the add/filtering-for-job-meta branch April 17, 2018 17:51
@jom jom mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom requested changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees

@alexsanford alexsanford

Labels
None yet
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsanford @jom