Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the application URL #1456

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Simplify the application URL #1456

merged 2 commits into from
Apr 17, 2018

Conversation

alexsanford
Copy link
Contributor

Fixes #635

Changes proposed in this Pull Request:

  • Simplify the displayed application URL to just the host.

Testing instructions:

  • Ensure the Applications extension is not activated.
  • Set the Application URL on a job listing.
  • View that job listing on the frontend and click Apply For Job.
  • Inspect the simplified link. Ensure that clicking the link takes you to the correct page in a new tab.

@alexsanford alexsanford self-assigned this Apr 17, 2018
@alexsanford alexsanford requested review from jom and donnapep April 17, 2018 15:27
jom
jom approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Template version needs updating to 1.31.0 and then 🚢 🌮

@alexsanford alexsanford merged commit 6d09c0a into master Apr 17, 2018
@alexsanford alexsanford deleted the fix/apply-url branch April 17, 2018 15:42
@jom jom added this to the 1.31.0 milestone Apr 18, 2018
@jom jom mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees

@alexsanford alexsanford

Labels
None yet
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsanford @jom