Emails should have contexts and use template paths for their context #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsanford
reviewed
Apr 25, 2018
| * @param WP_Job_Manager_Email $email Email object for the notification. | ||
| * @param bool $sent_to_admin True if this is being sent to an administrator. | ||
| * @param bool $plain_text True if the email is being sent as plain text. | ||
| * @param string $email_notification_key Email object for the notification. |
| * Checks for an alternative email template segment in the template path specified by the current email. | ||
| * Useful to provide alternative email headers and footers for a specific WPJM extension plugin. | ||
| * | ||
| * @param string $email_notification_key Email object for the notification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I started thinking about how we'd implement this in our extension plugins, I realized we want to give emails a context so they can appear in different setting screens and they should follow a template path and default template path for overriding in plugins.
@alexsanford I also closed that circular dependency for the template file name method 😉