Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS code formatting fixes #1534

Merged
merged 58 commits into from
Jul 2, 2018
Merged
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
3afdc61
Add PHPCompatibility PHPCS rules
jom Jun 27, 2018
9863c54
Change PHPCS to more closely match Woo
jom Jun 27, 2018
a5e3ae9
PHPCS: Auto formatting fixes for all PHP files
jom Jun 27, 2018
3326012
PHPCS: Add periods at end of single line comments
jom Jun 27, 2018
d817576
PHPCS: Remove all VIP rules
jom Jun 27, 2018
8bace7d
PHPCS: Add periods at end of param comments
jom Jun 27, 2018
5204c68
PHPCS: Add full stop at end of return comments
jom Jun 27, 2018
44a0694
PHPCS: Remove some rules that aren't a priority right now
jom Jun 27, 2018
ebaafc9
PHPCS: Fix some strange auto-fixes
jom Jun 28, 2018
d9259fe
PHPCS: Remove usage of `extract()` in shortcodes
jom Jun 28, 2018
a565086
PHPCS: PHP DocBlock fixes for return types and thrown items
jom Jun 28, 2018
ef931d8
Remove duplicate keys from usage data
jom Jun 28, 2018
999c9c3
Code Smell: Use parent constructor in widgets
jom Jun 28, 2018
59d2400
Bug: Don't reuse same var names in child foreach loop
jom Jun 28, 2018
6688a30
Merge branch 'master' into change/phpcs-fixes
jom Jun 28, 2018
771fbd2
PHPCS: Formatting fix from master merge of wp-job-manager.php
jom Jun 28, 2018
37a2b65
PHPCS: Expanded method args with array, start array new declaration o…
jom Jun 28, 2018
56abbe7
PHPCS: Add auto formatting to tests
jom Jun 28, 2018
c7e8f00
PHPCS: Auto fixes for tests
jom Jun 28, 2018
1ae3420
PHPCS: Yoda, docblock, some translation comments
jom Jun 28, 2018
73ec587
PHPCS: 3rd party code cleanup
jom Jun 28, 2018
51ecd6a
PHPCS: Abstract class documentaiton cleanup
jom Jun 28, 2018
4b30ea0
PHPCS: Escape LIKE replacement vars correctly in admin CPT
jom Jun 29, 2018
c13231e
PHPCS: Admin code fixes
jom Jun 29, 2018
b35d776
PHPCS: Expand and ignore XSS on pre-escaped setting fields
jom Jun 29, 2018
6d914da
PHPCS: Minor formatting and translation fixes for email notifications
jom Jun 29, 2018
a0d23bc
PHPCS: Minor fixes for helper and form classes
jom Jun 29, 2018
1b9f6d1
PHPCS: Mainly docblock fixes for REST API classes
jom Jun 29, 2018
11b1dee
PHPCS: Minor fixes to widget formatting and translation hints
jom Jun 29, 2018
b51a263
PHPCS: Minor fixes and docblock changes for root includes files
jom Jun 29, 2018
d0a477e
PHPCS: Adds additional escaping, formatting, and minor doc changes to…
jom Jun 29, 2018
acde6aa
PHPCS: Formatting, escaping, and translator hints for post type class
jom Jun 29, 2018
fbde49a
PHPCS: Minor rule ignoring for category walker
jom Jun 29, 2018
19bd42a
PHPCS: Update yoda and remove inside var setting in deprecated functions
jom Jun 29, 2018
c5a2e86
PHPCS: Update core functions
jom Jun 29, 2018
2b3ea96
PHPCS: Fix issues with template functions
jom Jun 29, 2018
7b03665
PHPCS: Fix issues with core WP_Job_Manager class
jom Jun 29, 2018
4194575
PHPCS: Add some globally ignored rules
jom Jun 29, 2018
8b8b4ad
PHPCS/Tests: Update tests for updated email functions
jom Jun 29, 2018
e8aee37
PHPCS: Revert some changes in cache helper and cpt
jom Jun 29, 2018
d0c43d6
PHPCS: Revert change to not return when echo-ing in template functions
jom Jun 29, 2018
7aaf50e
Update renamed callbacks for sending notifications
jom Jun 29, 2018
62d06b7
PHPCS: Revert change on settings for page input
jom Jun 29, 2018
7b0d873
PHPCS: Fix some whitespace autofix errors in writepanels
jom Jul 1, 2018
15330f7
PHPCS: Add automatic PHPCS checking on pre-commit hook. Mu-ha-ha-ha.
jom Jul 1, 2018
2d58bb7
PHPCS: Escape translation in settings file
jom Jul 1, 2018
e058f5a
PHPCS: Collapse some auto-changes for if statements
jom Jul 1, 2018
cc670d7
PHPCS: Remove unnecessary `? true : false` casting
jom Jul 1, 2018
91fee33
PHPCS: Format SQL prepare statements in post types
jom Jul 1, 2018
bd79c18
PHPCS: Fix issue with auto formatting in html license view
jom Jul 1, 2018
7658c29
PHPCS: Don't escape before/after widget and before/after title
jom Jul 1, 2018
c7735d5
PHPCS: Fix issues with changed form validation method
jom Jul 2, 2018
a3b335e
PHPCS: Fix minor issue in addons file
jom Jul 2, 2018
2a77dfe
PHPCS: Fix minor issue in admin file
jom Jul 2, 2018
d110743
PHPCS: Minor code formatting fixes
jom Jul 2, 2018
235549c
Remove redundant response check in helper
jom Jul 2, 2018
7d2a6f5
PHPCS: Add explicit rule exception for wp_new_user_notification
jom Jul 2, 2018
847b692
PHPCS: Revert change to selected_category attribute in `[jobs]`
jom Jul 2, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"require-dev" : {
"phpunit/phpunit": "^5.7",
"wp-coding-standards/wpcs": "^0.14.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.4.4"
"dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
"wimg/php-compatibility": "^8.1"
}
}
175 changes: 143 additions & 32 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions includes/3rd-party/all-in-one-seo-pack.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php
/**
* Adds additional compatibility with All in One SEO Pack.
*
* @package wp-job-manager
*/

/**
Expand Down
2 changes: 2 additions & 0 deletions includes/3rd-party/jetpack.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php
/**
* Adds additional compatibility with Jetpack.
*
* @package wp-job-manager
*/

/**
Expand Down
2 changes: 2 additions & 0 deletions includes/3rd-party/polylang.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php
/**
* Only load these if Polylang plugin is installed and active.
*
* @package wp-job-manager
*/

/**
Expand Down
2 changes: 2 additions & 0 deletions includes/3rd-party/rp4wp.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php
/**
* Adds additional compatibility with Related Post for WordPress.
*
* @package wp-job-manager
*/

add_filter( 'rp4wp_get_template', 'wpjm_rp4wp_template', 10, 3 );
Expand Down
9 changes: 7 additions & 2 deletions includes/3rd-party/wp-all-import.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php
/**
* Adds additional compatibility with WP All Import.
*
* @package wp-job-manager
*/

add_action( 'pmxi_saved_post', 'wpjm_pmxi_saved_post', 10, 1 );
Expand All @@ -13,8 +15,11 @@
function wpjm_pmxi_saved_post( $post_id ) {
if ( 'job_listing' === get_post_type( $post_id ) ) {
WP_Job_Manager_Post_Types::instance()->maybe_add_default_meta_data( $post_id );
if ( ! WP_Job_Manager_Geocode::has_location_data( $post_id ) && ( $location = get_post_meta( $post_id, '_job_location', true ) ) ) {
WP_Job_Manager_Geocode::generate_location_data( $post_id, $location );
if ( ! WP_Job_Manager_Geocode::has_location_data( $post_id ) ) {
$location = get_post_meta( $post_id, '_job_location', true );
if ( $location ) {
WP_Job_Manager_Geocode::generate_location_data( $post_id, $location );
}
}
}
}
Loading