1.31.1 Release

[jom]

This release is slated for Wednesday, 2018-07-11 (pending major issues).

Download (Beta 2) | PRs | Issues | Diff

Overview and Testing

While this release is small in terms of functionality impact, it is massive in terms of lines of modified/added/removed code. We'll be heavily testing this release, however, this should be backwards compatible with 1.31.0. Still, we highly recommend theme and plugin authors test their product with this beta release. We had two massive PRs in this release:

• Adds additional escaping throughout plugin (VIP) #1495: This PR added escaping where it was missing in the plugin. Many of these are with string translations or output that shouldn't be affected by themes/plugins, but please test to make sure you don't see escaped HTML anywhere it should be. Thanks to @tomjn for all his work on this.
• PHPCS code formatting fixes #1534: This PR worked on cleaning up our PHPCS violations, including:
  • Adding some additional escaping.
  • Remove all unnecessary uses of extract(). Themes and plugins that override the templates related to [jobs] should verify their products aren't effected by the change.
  • Added translation hints where there were placeholders in translated strings.
  • Whitespace fixes.
  • Logic/yoda swaps.
  • Shift to always use strict comparisons with ===, !==, and in_array( $needle, $haystack, true ).
  • All devs should do a composer install on master branch to install the pre-commit hook that will prevent further PHPCS issues from entering codebase. Some ignored rules will be handled soon.

Additionally, the following PRs should be tested using the testing instructions provided inside the PR or related issue:

• Allow listings to be moved to draft without change to expiration #1529: Allow job listings' post status to be set to Draft and not be affected by auto-expiring.
• Add suggested text for the site privacy policy #1522: Suggest Privacy Policy text.
• Add option to show logo in Recent Jobs widget #1509: Add option to show logo in Recent Jobs widget.
• Use strict sanitization for usernames #1491: Strict sanitization of usernames.

Changelog

= 1.31.1 =
* Enhancement: Add option to show company logo in Recent Jobs widget. (@RajeebTheGreat)
* Enhancement: Suggest additional cookie information on Privacy Policy page.
* Enhancement: Add WPJM related meta data to user data extract.
* Fix: Tightened the security of the plugin with additional string escaping.
* Fix: Issue with map link in admin backend. (@RajeebTheGreat)
* Fix: No longer auto-expire job listings in Draft status.
* Fix: Issue with undefined index error in WP admin. (@albionselimaj)
* Fix: Issue with duplicate usernames preventing submission of job listings. (@timothyjensen)
* Dev: Widespread code formatting cleanup throughout the plugin. 

Known Issues

Beta 2 (2018-07-05)

Diff from Beta 1

• @tripflex's field editor allows HTML in field labels. Switch field label output escaping to wp_kses_post() instead of esc_html(). (b55a749)
• Duplicate post issue caused by a merge/rebase issue. (382a5a0)

Beta 1 (2018-07-04)

• Escaped checkbox labels in admin settings
• Removes embedded company videos
• Removes HTML that should be allowed from some calls to wpjm_get_the_job_title()
• templates/content-widget-job_listing.php needs to check for $show_logo because it is shared in the widgets (we should probably add this to the other widget)

Additional Information

This release PR should never be merged. Instead, once completed, we'll tag the release and then cherry-pick the updates to the version number into a clean PR along with additional fixes. Since branching it from master, I've reverted the changes related to the upcoming blocks (as none will be there in this release).