Add promote modal on job save #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatho
commented
Jul 17, 2023
renatho
commented
Jul 17, 2023
| if ( 'edit-job_listing' !== $screen->id ) { | ||
| return; | ||
|
|
||
| if ( in_array( $screen->id, [ 'edit-job_listing', 'job_listing' ], true ) ) { // Job listing and job editor. |
There was a problem hiding this comment.
This change is to also load the promote modal on the job editor page.
renatho
force-pushed
the
add/promote-modal-on-job-save
branch
2 times, most recently
from
619ce4a to
ac137c0
Compare
Base automatically changed from
add/fetch-promoted-template
to
feature/promoted-jobs
July 17, 2023 18:25
renatho
commented
Jul 17, 2023
| * | ||
| * @return {Function} Unsubscribe function. | ||
| */ | ||
| const editorLifecycle = ( { |
There was a problem hiding this comment.
Borrowed from Sensei LMS.
Borrowed from Sensei LMS.
This reverts commit 75c38d5.
renatho
force-pushed
the
add/promote-modal-on-job-save
branch
from
44add0b to
72c04ac
Compare
renatho
force-pushed
the
add/promote-modal-on-job-save
branch
from
c18278d to
f5866b0
Compare
renatho
commented
Jul 17, 2023
| @@ -0,0 +1,49 @@ | |||
| /** | |||
There was a problem hiding this comment.
This logic was extracted from the admin.js, so we can use it properly in the editor.
renatho
commented
Jul 17, 2023
| @@ -0,0 +1,21 @@ | |||
| /** | |||
There was a problem hiding this comment.
It was also extracted, just in order to make it a module instead of a global function.
renatho
commented
Jul 17, 2023
| @@ -128,6 +128,21 @@ public function admin_enqueue_scripts() { | |||
| ); | |||
| } | |||
|
|
|||
| if ( 'job_listing' === $screen->id && $screen->is_block_editor() ) { // Check if it's block editor in job post. | |||
There was a problem hiding this comment.
It seems the standard to include the JS files is here, so I included a JS for the job editor here, including a global variable for the promote URL.
jom
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2518
Changes proposed in this Pull Request
Testing instructions
Screenshot / Video
Screen.Recording.2023-07-17.at.17.51.21.mov