Rename licence -> license throughout codebase #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
commented
Aug 3, 2023
| $this->add_error( $product_slug, __( 'license is not active.', 'wp-job-manager' ) ); | ||
| return; | ||
| } | ||
| $this->api->deactivate( | ||
| [ | ||
| 'api_product_id' => $product_slug, | ||
| 'licence_key' => $licence['licence_key'], | ||
| 'email' => $licence['email'], | ||
| 'license_key' => $license['license_key'], |
There was a problem hiding this comment.
This is changed from the API's request method.
aaronfc
reviewed
Aug 3, 2023
|
@aaronfc Thanks for the review! I'll hold off merging until the parent PR is merged. |
Merged
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built off of #2552
While working on #2552, I realized we have a very brittle setup with the usage of
licencevs (US)license. This finally standardizes it to uselicenseand migrates the licenses appropriately. Our strings should previously all been updated, but this switches over the code/options.Changes proposed in this Pull Request
licencetolicensein code and options.Testing instructions
trunk, activate licenses for products.Deprecated Code
WP_Job_Manager_Helper::has_licenced_products->WP_Job_Manager_Helper::has_licensed_productsWP_Job_Manager_Helper::get_plugin_licence->WP_Job_Manager_Helper::get_plugin_licenseWP_Job_Manager_Helper::licence_output->WP_Job_Manager_Helper::licence_outputWP_Job_Manager_Helper::activate_licence->WP_Job_Manager_Helper::activate_licenseWP_Job_Manager_Helper::deactivate_licence->WP_Job_Manager_Helper::deactivate_license