Add usage tracking for settings #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gikaragia
reviewed
Apr 4, 2024
| @@ -322,7 +322,6 @@ public function clear_fields() { | |||
| * Enqueue the scripts for the form. | |||
| */ | |||
| public function enqueue_scripts() { | |||
There was a problem hiding this comment.
Is this actually called from somewhere?
There was a problem hiding this comment.
Oh looks like I had the warning about this because it's called in the Applications add-on's form (WP_Job_Manager_Applications_Apply) that extends this class. Since this is a generic base class used all around I'd keep the method even if we don't use it now in core.
| @@ -285,6 +312,7 @@ protected function init_settings() { | |||
| 'type' => 'text', | |||
| 'placeholder' => __( 'e.g. USD', 'wp-job-manager' ), | |||
| 'attributes' => [], | |||
| 'track' => 'bool', | |||
There was a problem hiding this comment.
Fixing these in 20d4d78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2797
Changes Proposed in this Pull Request
trackkey in the settings configTesting Instructions
job_manager_usage_tracking_send_usage_datawpjm_stats_logevent in Tracks Live View. Username can be used to filter, it's the full site URL (Likehttp://paper.local)settings_fields are included