Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images #68

Closed
iamtakashi opened this issue May 20, 2020 · 2 comments
Closed

Images #68

iamtakashi opened this issue May 20, 2020 · 2 comments

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented May 20, 2020

Pattern 81

<!-- wp:jetpack/layout-grid {"column1DesktopSpan":9,"column1TabletSpan":4,"column1MobileSpan":4,"column2DesktopSpan":3,"column2TabletSpan":4,"column2MobileSpan":4,"className":"column1-desktop-grid__span-9 column1-desktop-grid__row-1 column2-desktop-grid__span-3 column2-desktop-grid__start-10 column2-desktop-grid__row-1 column1-tablet-grid__span-4 column1-tablet-grid__row-1 column2-tablet-grid__span-4 column2-tablet-grid__start-5 column2-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1 column2-mobile-grid__span-4 column2-mobile-grid__row-2"} -->
<div class="wp-block-jetpack-layout-grid alignfull column1-desktop-grid__span-9 column1-desktop-grid__row-1 column2-desktop-grid__span-3 column2-desktop-grid__start-10 column2-desktop-grid__row-1 column1-tablet-grid__span-4 column1-tablet-grid__row-1 column2-tablet-grid__span-4 column2-tablet-grid__start-5 column2-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1 column2-mobile-grid__span-4 column2-mobile-grid__row-2"><!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:jetpack/layout-grid {"addGutterEnds":false,"column1DesktopSpan":8,"column1TabletSpan":8,"column1MobileSpan":4,"column2DesktopSpan":6,"column2DesktopOffset":6,"column2TabletSpan":4,"column2MobileSpan":4,"className":"column1-desktop-grid__span-8 column1-desktop-grid__row-1 column1-tablet-grid__span-8 column1-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1"} -->
<div class="wp-block-jetpack-layout-grid alignfull column1-desktop-grid__span-8 column1-desktop-grid__row-1 column1-tablet-grid__span-8 column1-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1 wp-block-jetpack-layout-gutter__nowrap"><!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:image {"id":1015,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://dotcompatterns.files.wordpress.com/2020/05/autri-taheri-wjdu5pkwyeo-unsplash-1.jpg" alt="" class="wp-image-1015"/></figure>
<!-- /wp:image --></div>
<!-- /wp:jetpack/layout-grid-column --></div>
<!-- /wp:jetpack/layout-grid -->

<!-- wp:jetpack/layout-grid {"addGutterEnds":false,"column1DesktopSpan":3,"column1DesktopOffset":1,"column1TabletSpan":4,"column1MobileSpan":4,"column2DesktopSpan":4,"column2TabletSpan":4,"column2MobileSpan":4,"column3DesktopSpan":4,"column3TabletSpan":8,"column3MobileSpan":4,"className":"column1-desktop-grid__span-3 column1-desktop-grid__start-2 column1-desktop-grid__row-1 column2-desktop-grid__span-4 column2-desktop-grid__start-5 column2-desktop-grid__row-1 column3-desktop-grid__span-4 column3-desktop-grid__start-9 column3-desktop-grid__row-1 column1-tablet-grid__span-4 column1-tablet-grid__row-1 column2-tablet-grid__span-4 column2-tablet-grid__start-5 column2-tablet-grid__row-1 column3-tablet-grid__span-8 column3-tablet-grid__row-2 column1-mobile-grid__span-4 column1-mobile-grid__row-1 column2-mobile-grid__span-4 column2-mobile-grid__row-2 column3-mobile-grid__span-4 column3-mobile-grid__row-3"} -->
<div class="wp-block-jetpack-layout-grid alignfull column1-desktop-grid__span-3 column1-desktop-grid__start-2 column1-desktop-grid__row-1 column2-desktop-grid__span-4 column2-desktop-grid__start-5 column2-desktop-grid__row-1 column3-desktop-grid__span-4 column3-desktop-grid__start-9 column3-desktop-grid__row-1 column1-tablet-grid__span-4 column1-tablet-grid__row-1 column2-tablet-grid__span-4 column2-tablet-grid__start-5 column2-tablet-grid__row-1 column3-tablet-grid__span-8 column3-tablet-grid__row-2 column1-mobile-grid__span-4 column1-mobile-grid__row-1 column2-mobile-grid__span-4 column2-mobile-grid__row-2 column3-mobile-grid__span-4 column3-mobile-grid__row-3 wp-block-jetpack-layout-gutter__nowrap"><!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:image {"id":1002,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://dotcompatterns.files.wordpress.com/2020/05/autri-taheri-ceyi_5a-hcg-unsplash.jpg" alt="" class="wp-image-1002"/></figure>
<!-- /wp:image --></div>
<!-- /wp:jetpack/layout-grid-column -->

<!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:image {"id":1005,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://dotcompatterns.files.wordpress.com/2020/05/oliver-sjostrom-2ojhvhpxrza-unsplash.jpg" alt="" class="wp-image-1005"/></figure>
<!-- /wp:image --></div>
<!-- /wp:jetpack/layout-grid-column -->

<!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:image {"id":1001,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://dotcompatterns.files.wordpress.com/2020/05/autri-taheri-w72una-s9ry-unsplash.jpg" alt="" class="wp-image-1001"/></figure>
<!-- /wp:image --></div>
<!-- /wp:jetpack/layout-grid-column --></div>
<!-- /wp:jetpack/layout-grid --></div>
<!-- /wp:jetpack/layout-grid-column -->

<!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:paragraph {"className":"margin-bottom-none","style":{"typography":{"fontSize":14}}} -->
<p class="margin-bottom-none" style="font-size:14px">Vol.3</p>
<!-- /wp:paragraph -->

<!-- wp:heading {"level":3,"className":"margin-top-none","style":{"typography":{"fontSize":24,"lineHeight":"1.2"}}} -->
<h3 class="margin-top-none" style="line-height:1.2;font-size:24px">5am, the Beach</h3>
<!-- /wp:heading -->

<!-- wp:paragraph {"style":{"typography":{"fontSize":14}}} -->
<p style="font-size:14px">As long as I was on the path I walked hard, but when I came to the black beach I had to run. For the tide was now nearly flowed; and to get through with my powder dry between the surf and the steep hill, took all the quickness I possessed. As it was, even, the wash caught me to the knees, and I came near falling on a stone. All this time the hurry I was in, and the free air and smell of the sea, kept my spirits lively; but when I was once in the bush and began to climb the path I took it easier. </p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"style":{"typography":{"fontSize":14}}} -->
<p style="font-size:14px">The fearsomeness of the wood had been a good bit rubbed off for me by Master Case’s banjo-strings and graven images, yet I thought it was a dreary walk, and guessed, when the disciples went up there, they must be badly scared. The light of the lantern, striking among all these trunks and forked branches and twisted rope-ends of lianas, made the whole place, or all that you could see of it, a kind of a puzzle of turning shadows. They came to meet you, solid and quick like giants, and then span off and vanished; they hove up over your head like clubs, and flew away into the night like birds. The floor of the bush glimmered with dead wood, the way the match-box used to shine after you had struck a lucifer. Big, cold drops fell on me from the branches overhead like sweat. There was no wind to mention; only a little icy breath of a land-breeze that stirred nothing; and the harps were silent.</p>
<!-- /wp:paragraph --></div>
<!-- /wp:jetpack/layout-grid-column --></div>
<!-- /wp:jetpack/layout-grid -->
@alaczek
Copy link
Contributor

alaczek commented May 21, 2020

I like this pattern. The only thing about it it's a bit overwhelming when you start editing it, due to the nested layout grids. Not sure there is a way around that tho :|

image

@iamtakashi
Copy link
Contributor Author

Yeah, there are some slight issues in the editor style, but when the block lets us turn off the gridline it should help: Automattic/block-experiments#89

In terms of the extra vertical margins that we see in the block should be fixed when this PR
gets merged. Automattic/block-experiments#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants