Add a few small fixes. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
force-pushed
the
update/layout-grid
branch
from
4034262 to
d04d057
Compare
|
Rebased and tested again. This branch:
Master:
So yes, this is still necessary, a good visual consistency improvement. |
|
This works as described, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra vertical spacing is reported in Varia themes, that use this block a lot:
Automattic/themes#1798
This is because in the editor, every single block, including block containers, has an intrinsic top and bottom margin.
This unsets that margin for the layout grid, making sure editor and frontend look the same:
It has a side-effect — this doesn't look great:
However, it's still accurate! So in that vein I'm tempted to keep that as is. We can make rules to space this out, but I lean towards not doing that. If you really want to insert multiple layout grids after each other, it feels correct to show that they will snug up against each other.
Finally, it fixes an issue where on some themes, the end-gutter option wouldn't work. Pictured below, end gutters not working:
It works in this PR, rest assured.
I would not call a release of this urgent — fine to bundle it up with other patches that may need to be made.