feat(#331): Literate Haskell Support #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
requested changes
Jan 6, 2025
| @@ -0,0 +1,11 @@ | |||
| [package] | |||
| name = "harper-literate-haskell" | |||
There was a problem hiding this comment.
Make sure this includes all the keys that the other public crates include (repository, etc).
| } | ||
|
|
||
| impl Masker for LiterateHaskellMasker { | ||
| fn create_mask(&mut self, source: &[char]) -> harper_core::Mask { |
There was a problem hiding this comment.
Is there a language specification you're referencing for this implementation? If so, make sure to link it here.
| @@ -0,0 +1,145 @@ | |||
| use harper_core::{CharStringExt, Mask, Masker, Span}; | |||
|
|
|||
| pub struct LiterateHaskellMasker { | |||
There was a problem hiding this comment.
Give us a brief description of what this does. What part of the text are we masking?
Keep in mind that this will get posted on crates.io and therefore docs.rs, so we want doc-comments that somewhat explain things.
| let source = text.chars().collect_vec(); | ||
| let parser = LiterateHaskellParser; | ||
|
|
||
| if let Some(new_dict) = parser.create_ident_dict(&source) { |
There was a problem hiding this comment.
Could this be generalized to the other languages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser does not support parsing the actual code beyond extracting identifiers, but I don't know how that would be implemented considering the vastly different contexts.
If we were able to, using CommentParser would be great. It is a little weird to have comments in your code when it's literate programming anyway, but I can see it happening.
Will need to be revisited before/after merging #302 because of the changes to the
ParserandMaskertraits.