Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fetchLinkSuggestions #135

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

akirk
Copy link
Member

@akirk akirk commented May 3, 2022

Fixes the breaking Gutenberg change WordPress/gutenberg#40052, see also Automattic/blocks-everywhere#25

Description

__experimentalFetchLinkSuggestions is being renamed to fetchLinkSuggestions

Solution

I've renamed the function call which was already written in a defensive matter. I've changed the code so that it falls back to a potentially existing __experimentalFetchLinkSuggestions but maybe this is not necessary. I haven't seen this being called anywhere in the codebase.

cc @getdave

@akirk akirk requested review from mirka and johngodley May 3, 2022 09:04
Copy link

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Being defensive is probably wise.

Based on feedback, I think we'll probably end up putting in a formal deprecation in Gutenberg when we change the API but who knows.

Thanks for being proactive here 👏

@johngodley
Copy link
Member

Thanks Alex!

@johngodley johngodley deleted the update-fetch-link-suggestions branch May 17, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants