Skip to content

Commit

Permalink
Newsletter launchpad: replace preview task with "launch site" (#41344)
Browse files Browse the repository at this point in the history
* Newsletter goal uses "launch site" task instead of "preview site"

* Remove unused "preview_site" task

This task was added in #41158 specifically for the
intent-newsletter-goal intent. Since that launchpad no longer uses the
task, we can safely remove it.

* changelog

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/13002123490

Upstream-Ref: Automattic/jetpack@df67099
  • Loading branch information
p-jackson authored and matticbot committed Jan 28, 2025
1 parent 3488495 commit 4cd4d08
Show file tree
Hide file tree
Showing 7 changed files with 91 additions and 99 deletions.
60 changes: 30 additions & 30 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions jetpack_vendor/automattic/jetpack-mu-wpcom/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ This is an alpha version! The changes listed here are not final.
- Code: Use function-style exit() and die() with a default status code of 0.
- Coming Soon: Add more checks to the ETK version comparison.
- Launchpad: Launch site task disabled for launched sites
- Launchpad: Replace newsletter preview task with launch task
- Remove duplicate views: Enhance notices
- Render the Global Styles frontend bar separately from the .com launch bar.
- Update background pattern image
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,15 +181,6 @@ function wpcom_launchpad_get_task_definitions() {
return '/me/account';
},
),
'preview_site' => array(
'get_title' => function () {
return __( 'Preview your site', 'jetpack-mu-wpcom' );
},
'is_complete_callback' => 'wpcom_launchpad_is_task_option_completed',
'get_calypso_path' => function ( $task, $default, $data ) {
return '/view/' . $data['site_slug_encoded'];
},
),

// Newsletter pre-launch tasks.
'first_post_published_newsletter' => array(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function wpcom_launchpad_get_task_list_definitions() {
'start_building_your_audience',
'customize_welcome_message',
'first_post_published',
'preview_site',
'site_launched',
),
'is_enabled_callback' => 'wpcom_launchpad_get_fullscreen_enabled',
),
Expand Down
2 changes: 1 addition & 1 deletion jetpack_vendor/i18n-map.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
),
'jetpack-mu-wpcom' => array(
'path' => 'jetpack_vendor/automattic/jetpack-mu-wpcom',
'ver' => '6.2.0-alpha1738009945',
'ver' => '6.2.0-alpha1738029568',
),
'jetpack-password-checker' => array(
'path' => 'jetpack_vendor/automattic/jetpack-password-checker',
Expand Down
Loading

0 comments on commit 4cd4d08

Please sign in to comment.