Account Protection: Add password detection flow #67659
Annotations
10 errors and 11 warnings
Run phpcs:
projects/packages/account-protection/src/class-password-reset-email.php#L1
There must be no blank lines before the file comment (Squiz.Commenting.FileComment.SpacingAfterOpen)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L1
There must be no blank lines before the file comment (Squiz.Commenting.FileComment.SpacingAfterOpen)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L72
Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L77
Empty IF statement detected (Generic.CodeAnalysis.EmptyStatement.DetectedIf)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L88
Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L123
Doc comment for parameter "$setting" missing (Squiz.Commenting.FunctionComment.MissingParamTag)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L141
Doc comment for parameter "$user_id" missing (Squiz.Commenting.FunctionComment.MissingParamTag)
|
Run phpcs:
projects/packages/account-protection/src/class-account-protection.php#L63
Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
|
Run phpcs:
projects/packages/account-protection/src/class-account-protection.php#L63
Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
|
Run phpcs:
projects/packages/account-protection/src/templates/password-detection-template.php#L1
Missing file doc comment (Squiz.Commenting.FileComment.Missing)
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Run phpcs:
projects/packages/account-protection/src/assets/jetpack-logo.php#L1
No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them. (Internal.NoCodeFound)
|
Run phpcs:
projects/packages/account-protection/src/class-password-reset-email.php#L44
Unused function parameter $email. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
|
Run phpcs:
projects/packages/account-protection/src/class-password-reset-email.php#L46
parse_url() is discouraged because of inconsistency in the output across PHP versions; use wp_parse_url() instead. (WordPress.WP.AlternativeFunctions.parse_url_parse_url)
|
Run phpcs:
projects/packages/account-protection/src/class-password-reset-email.php#L47
Unused variable $domain_name. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
|
Run phpcs:
projects/packages/account-protection/src/class-password-reset-email.php#L52
Unused variable $password_reset_link. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L59
wp_redirect() found. Using wp_safe_redirect(), along with the "allowed_redirect_hosts" filter if needed, can help avoid any chances of malicious redirects within code. It is also important to remember to call exit() after a redirect so that no other unwanted code is executed. (WordPress.Security.SafeRedirect.wp_redirect_wp_redirect)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L68
wp_redirect() found. Using wp_safe_redirect(), along with the "allowed_redirect_hosts" filter if needed, can help avoid any chances of malicious redirects within code. It is also important to remember to call exit() after a redirect so that no other unwanted code is executed. (WordPress.Security.SafeRedirect.wp_redirect_wp_redirect)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L81
Unused variable $header_title. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L82
Unused variable $page_title. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
|
Run phpcs:
projects/packages/account-protection/src/class-password-detection.php#L83
Unused variable $content. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
|
Loading