Block editor: update deprecated component prop

See #27795 position prop is now deprecated for Dropdown and URLPopover, we must switch to the placement prop instead.
Automattic · Mar 14, 2023 · b176e8c · b176e8c
1 parent 24640dd
commit b176e8c
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 6 deletions.
diff --git a/projects/packages/videopress/changelog/update-position-placement-prop b/projects/packages/videopress/changelog/update-position-placement-prop
@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+General: update deprecated core prop
diff --git a/projects/packages/videopress/src/client/admin/components/video-details-actions/index.tsx b/projects/packages/videopress/src/client/admin/components/video-details-actions/index.tsx
@@ -45,7 +45,7 @@ const VideoDetailsActions = ( {
 	return (
 		<>
 			<Dropdown
-				position="bottom center"
+				placement="bottom center"
 				className={ styles.dropdown }
 				renderToggle={ ( { isOpen, onToggle } ) => (
 					<Button

diff --git a/projects/packages/videopress/src/client/admin/components/video-quick-actions/index.tsx b/projects/packages/videopress/src/client/admin/components/video-quick-actions/index.tsx
@@ -121,7 +121,7 @@ const ThumbnailActionsDropdown = ( {
 
 	return (
 		<Dropdown
-			position="bottom left"
+			placement="bottom left"
 			renderToggle={ ( { isOpen, onToggle } ) => (
 				<div ref={ setAnchor }>
 					<Button
@@ -187,7 +187,7 @@ const PrivacyActionsDropdown = ( {
 
 	return (
 		<Dropdown
-			position="bottom left"
+			placement="bottom left"
 			renderToggle={ ( { isOpen, onToggle } ) => (
 				<div ref={ setAnchor }>
 					<Button

diff --git a/projects/packages/videopress/src/client/admin/components/video-thumbnail/index.tsx b/projects/packages/videopress/src/client/admin/components/video-thumbnail/index.tsx
@@ -85,7 +85,7 @@ export const VideoThumbnailDropdown = ( {
 	return (
 		<div className={ styles[ 'video-thumbnail-edit' ] }>
 			<Dropdown
-				position="bottom left"
+				placement="bottom left"
 				renderToggle={ ( { isOpen, onToggle } ) => (
 					<Button
 						variant="secondary"

diff --git a/...ackages/videopress/src/client/block-editor/blocks/video/components/poster-panel/index.tsx b/...ackages/videopress/src/client/block-editor/blocks/video/components/poster-panel/index.tsx
@@ -62,7 +62,7 @@ export function PosterDropdown( {
 	return (
 		<Dropdown
 			contentClassName="poster-panel__dropdown"
-			position="top left"
+			placement="top left"
 			renderToggle={ ( { isOpen, onToggle } ) => (
 				<Button
 					ref={ buttonRef }

diff --git a/projects/plugins/jetpack/changelog/update-position-placement-prop b/projects/plugins/jetpack/changelog/update-position-placement-prop
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Blocks: update deprecated component prop.
diff --git a/projects/plugins/jetpack/extensions/blocks/subscriptions/settings.js b/projects/plugins/jetpack/extensions/blocks/subscriptions/settings.js
@@ -135,7 +135,7 @@ export function NewsletterAccess( { accessLevel, setPostMeta, withModal = true }
 										focusOnMount
 										renderToggle={ ( { isOpen, onToggle } ) => (
 											<Button
-												isTertiary
+												variant="tertiary"
 												onClick={ onToggle }
 												aria-expanded={ isOpen }
 												aria-label={ sprintf(