Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Form Block: block validation errors cause by "Subscribe" / "Follow" text #18518

Closed
selectedselections opened this issue Jan 25, 2021 · 5 comments
Assignees
Labels
[Block] Subscriptions Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Comments

@selectedselections
Copy link

Steps to reproduce the issue

  1. Add a Subscription Form block to any post or page
  2. Notice that the block says "Subscribe" by default screenshot
  3. Publish the page and the text changes to "Follow" screenshot
  4. The text cannot be set to "Subscribe" unless you add an extra space, or some modification to the text in the editor screenshot

What I expected

I expected to be able to change the text to anything, or keep the button text as "Subscribe"

What happened instead

If the text in the editor is "Subscribe" it changes to "Follow" by default.

Screenshots
Screenshots included above

@selectedselections selectedselections added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. labels Jan 25, 2021
@sophiegyo
Copy link

sophiegyo commented Jan 25, 2021

I've just encountered another instance of this: 27245913-hc

Changing the text outright just did not work, but I added a . after the text the user wants:
https://d.pr/i/CVkEQE

After publishing, this is how it appears on the published page:
https://d.pr/i/USU65d

For some reason without that . the button text just shows the default "Follow" ("追蹤")

Edit: works with a space too; I added a space after the button text so it's "訂閱 " and that works fine:
https://d.pr/i/vS0Nau

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 25, 2021
@jeherve jeherve added [Block] Subscriptions and removed [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. labels Jan 25, 2021
@jeherve
Copy link
Member

jeherve commented Jan 25, 2021

Related: #18073 and #15474

@jeherve
Copy link
Member

jeherve commented Feb 4, 2021

Also reported in #18704 and #18706 .

@jeherve jeherve changed the title Subscription Form Block: "Subscribe" text cannot be published Subscription Form Block: block validation errors cause by "Subscribe" / "Follow" text Feb 4, 2021
@aaronrobertshaw aaronrobertshaw self-assigned this Feb 16, 2021
@aaronrobertshaw
Copy link
Contributor

I can replicate the issue with the "Subscribe" text being treated as the default and overridden on wpcom. However, I haven't encountered any block validation errors related to that text, as alluded to in this issue's title.

The code defaulting the button text to "Follow" has already been removed in #18550. It should be in the next release. Applying its associated diff, D56029-code, to my sandbox fixes the issue for me.

While trying to find validation errors, I did find an issue with this block when Jetpack is run alongside the Gutenberg plugin built from its master branch. In that instance, the validation error that occurs relates to custom font sizes missing in the attributes and therefore generating an invalid shortcode. I'll create a separate issue to track this and investigate that tomorrow.

In the meantime, can anyone confirm whether they experience validation errors due to the button text itself?

If not, I'd suggest closing this issue once #18550 & D56029-code land.

@aaronrobertshaw
Copy link
Contributor

Both the subscribe button text issue and validation errors from custom font sizes have been resolved. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants