Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions Block: Inconsistent placeholder text for subscribe button in wpcom between editor and front end #18704

Closed
andrewserong opened this issue Feb 4, 2021 · 1 comment
Labels
[Block] Subscriptions [Closed] Duplicate Duplicate of an existing issue. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@andrewserong
Copy link
Member

In wpcom, the placeholder text for the submit button in the Subscriptions block is rendered as Subscribe in the editor, however we override the defaults for the rendering of the block to use Follow if the block is rendered in a wpcom environment. This makes for a small but slightly confusing difference between the editor and the front end.

The subscribe button is set to use the word Follow in its default placeholder text in this line:

$defaults['subscribe_button'] = __( 'Follow' );

Shall we update this to use the word Subscribe instead so that it matches?

Steps to reproduce the issue

  1. In a dotcom simple site go to add a Subscriptions block (or select a design from /new that includes the block, such as Bowen)
  2. In the editor see that the default placeholder text for the submit button is Subscribe
  3. Publish or preview the post and you should see that the submit button says Follow

What I expected

Consistency between the editor view and the front end view. In this case as reported by @p-jackson I expected to see Subscribe instead of follow.

What happened instead

The button rendered with Follow as the placeholder text.

Screenshots

Editor view:

image

Front end view:

image

@jeherve
Copy link
Member

jeherve commented Feb 4, 2021

Closing as duplicate of #18518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Closed] Duplicate Duplicate of an existing issue. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants