Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTable: Move the CSS to make the block take only the space it needs #14672

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

scruffian
Copy link
Member

This is a different approach to #14553

Changes proposed in this Pull Request:

Testing instructions:

  • Open the Block inserter at the top left of the editor
  • Check that the block looks big in the block preview

Screenshot 2020-02-13 at 17 59 18

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] OpenTable labels Feb 13, 2020
@scruffian scruffian requested review from a team February 13, 2020 17:59
@scruffian scruffian self-assigned this Feb 13, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38888-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 343a88c

@glendaviesnz
Copy link
Contributor

Works for me. If you also add the following it vertically aligns it a bit better

.block-editor-block-preview__content [data-type='jetpack/opentable'][data-block] {
	margin-top: 0px;
	margin-bottom: 0px;
}

Screen Shot 2020-02-14 at 8 42 53 AM

@jeherve jeherve added this to the 8.3 milestone Feb 14, 2020
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 14, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but I do like @glendaviesnz's suggestion of taking the opportunity to center things a bit better.

@creativecoder
Copy link
Contributor

Please be sure to either test this against the latest version of the Gutenberg plugin or test the wpcom diff separately, as a block wrapper div was removed in Gutenberg since the latest WordPress release.

@scruffian
Copy link
Member Author

I tested against the latest Gutenberg and it works fine. I think it would be better to handle the centering in Core...

@scruffian scruffian merged commit 7a89807 into master Feb 18, 2020
@scruffian scruffian deleted the fix/opentable branch February 18, 2020 16:10
@scruffian
Copy link
Member Author

r203015-wpcom

@jeherve
Copy link
Member

jeherve commented Feb 24, 2020

@scruffian I wonder if this may have introduced an issue with the wide embed style:

image

Do you think you could take a look?

Thank you!

@jeherve jeherve removed [Status] Needs Changelog [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 25, 2020
@scruffian
Copy link
Member Author

@jeherve you're right, fix here: #14795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] OpenTable [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants