Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the tests for block gating so that they don't fail on wpcom #14778

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Update the tests for block gating so that they don't fail on wpcom #14778

merged 1 commit into from
Feb 24, 2020

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Feb 24, 2020 •
edited
Loading

The tests introduced in #14703 fail on WPCOM. This PR fixes them.

Changes proposed in this Pull Request:

  • We should lower the minimum version requirement for gutenberg as well as wp so that the test passes when the Gutenberg plugin is installed.

Testing instructions:

  • Run yarn docker:phpunit --filter test_returns_true_if_gutenberg_or_core_wp_version_greater_or_equal_to_minimum
  • Check that the tests on code-D38972 don't fail

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Feb 24, 2020
@scruffian scruffian requested review from a team February 24, 2020 14:52
@scruffian scruffian self-assigned this Feb 24, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 7272ff5

pablinos
pablinos approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my sandbox to see if the test passed, and it works nicely.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended Unit Tests labels Feb 24, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 24, 2020
jeherve
jeherve approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 24, 2020
@scruffian scruffian merged commit 442103f into master Feb 24, 2020
@scruffian scruffian deleted the fix/gating-tests branch February 24, 2020 17:11
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 24, 2020
@scruffian
Copy link
Member Author

r203276-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@pablinos pablinos pablinos approved these changes

Assignees

@scruffian scruffian

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended Unit Tests
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@scruffian @jetpackbot @pablinos @jeherve @matticbot