Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Use build-production-concurrently in tools/build-release-branch.sh #17906

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 25, 2020

Changes proposed in this Pull Request:

On my laptop, yarn run build-production takes about 4 minutes of wall
time, while yarn run build-production-concurrently takes about 2.5.

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Does the script still work?

Proposed changelog entry for your changes:

  • None needed.

…h.sh

On my laptop, `yarn run build-production` takes about 4 minutes of wall
time, while `yarn run build-production-concurrently` takes about 2.5.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Nov 25, 2020
@anomiex anomiex requested a review from jeherve November 25, 2020 20:31
@anomiex anomiex self-assigned this Nov 25, 2020
@jetpackbot
Copy link

Scheduled Jetpack release: December 1, 2020.
Scheduled code freeze: November 23, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17906

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 15dbe41

@jeherve jeherve added this to the 9.3 milestone Nov 26, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 26, 2020
@kraftbj kraftbj merged commit 44580ea into master Nov 30, 2020
@kraftbj kraftbj deleted the try/build-release-concurrently branch November 30, 2020 06:30
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants