Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Tiled Gallery Block: Aspect Ratio for Square Layout #21166

Merged
merged 15 commits into from
Nov 2, 2021
Merged

[RNMobile] Tiled Gallery Block: Aspect Ratio for Square Layout #21166

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
64f1950
Pass 'squared' class back to image for styling
Sep 23, 2021
f2ea815
Crop images in Tiled Gallery by default
Sep 27, 2021
0e317f6
Hide image block's caption component
Sep 27, 2021
1f16029
Remove uncessary code
Sep 27, 2021
5f068ac
Set aspect ratio of images so that they are squares
Sep 27, 2021
19139b0
Remove caption, as it's unused
Sep 27, 2021
5f6a329
Fix reference to CSS class
Sep 27, 2021
1500648
Remove 'hideImageCaption' context from PR's scope
Oct 4, 2021
128667a
Create native-specific index file to avoid impact to web
Oct 4, 2021
95f0e5c
Remove unused contexts from web-only index file
Oct 4, 2021
b773084
Merge branch 'rnmobile/add/tiled-gallery-block' into rnmobile/add/squ…
Oct 28, 2021
0e69603
Revert unecessary code removal
Oct 28, 2021
16913a3
Combine native-specific file into shared file
Oct 29, 2021
b463560
Remove layout constant, for clarity
Oct 29, 2021
03a8724
Merge branch 'rnmobile/add/tiled-gallery-block' into rnmobile/add/squ…
Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/plugins/jetpack/extensions/blocks/tiled-gallery/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const TiledGalleryEdit = props => {
url: image.url,
caption: image.caption,
alt: image.alt,
className: styles[ 'is-style-squared' ],
} );
} );

Expand Down
7 changes: 7 additions & 0 deletions projects/plugins/jetpack/extensions/blocks/tiled-gallery/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ const blockAttributes = {
},
},
},
imageCrop: {
type: 'boolean',
default: true,
},
guarani marked this conversation as resolved.
Show resolved Hide resolved
linkTo: {
default: 'none',
type: 'string',
Expand Down Expand Up @@ -292,6 +296,9 @@ export const settings = {
},
edit,
save,
providesContext: {
imageCrop: 'imageCrop',
},
deprecated,
example: {
attributes: exampleAttributes,
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/extensions/blocks/tiled-gallery/styles.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@
.horizontalBorderDark {
border-color: $gray-70;
}

.is-style-squared {
aspect-ratio: 1;
}