Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Hide Tiled Gallery settings #21278

Closed
wants to merge 1 commit into from
Closed

[RNMobile] Hide Tiled Gallery settings #21278

wants to merge 1 commit into from

Conversation

SiobhyB
Copy link

@SiobhyB SiobhyB commented Oct 4, 2021 •
edited
Loading

Gutenberg: WordPress/gutenberg#35315
Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#4070

Fixes #

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

Hide image block's caption and settings
9d71971 
As the image block's caption component and settings are not a part of the Tiled Gallery block's design, they're hidden with this commit. This is done by adding an "hideSettings" context and setting it to true. This is passed back to the image block, which is set to hide the unwanted settings when this context is detected.
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello SiobhyB! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D67774-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 4, 2021
@SiobhyB SiobhyB mentioned this pull request Oct 4, 2021
Closed
2 tasks
@SiobhyB SiobhyB changed the base branch from master to rnmobile/add/tiled-gallery-block October 4, 2021 09:32
SiobhyB pushed a commit that referenced this pull request Oct 4, 2021
Remove 'hideImageCaption' context from PR's scope
1500648 
In order to limit the PR's scope to the square aspect ratio, this commit removes the 'hideImageCaption'. New contexts for hiding the image block's caption and settings will be moved to #21278.
SiobhyB pushed a commit that referenced this pull request Nov 2, 2021
[RNMobile] Tiled Gallery Block: Aspect Ratio for Square Layout (#21166)
b11a395 
* Pass 'squared' class back to image for styling

* Crop images in Tiled Gallery by default

By adding an "imageCrop" and setting it to true, images in the Tiled Gallery will now appear cropped by default. This is important so that images don't appear unusually distorted when their shape is changed to be square.

* Hide image block's caption component

As the image block's caption component is not a part of the Tiled Gallery block's design, it's hidden with this commit. This is done by adding an "hideImageCaption" context and setting it to true. This is passed back to the image block, which is set to hide the component when this context is detected.

* Remove uncessary code

"imageCrop" and "hideImageCaption" don't need to be set as props.

* Set aspect ratio of images so that they are squares

With this commit, the image's aspect ratio is being set in Jetpack's CSS files. It was previously set in Gutenberg's files, but this wasn't inline with our guidelines for Jetpack code appearing in the open source project.

* Remove caption, as it's unused

* Fix reference to CSS class

The previous version of this code wasn't working as expected, as it included quotation marks. With this commit, the issue is fixed and the reference to the CSS class now works as expected.

* Remove 'hideImageCaption' context from PR's scope

In order to limit the PR's scope to the square aspect ratio, this commit removes the 'hideImageCaption'. New contexts for hiding the image block's caption and settings will be moved to #21278.

* Create native-specific index file to avoid impact to web

* Remove unused contexts from web-only index file

As a native-specific index file was introdued in 128667a, we no longer need to include contexts in the web-only index file, as they're only used with the apps.

* Revert unecessary code removal

The removal of the image's caption goes beyond the scope of this specific PR, so its removal is reverted with this PR.

* Combine native-specific file into shared file

As discussed here, there isn't currently a compelling need to keep the changes to the index file in a native-specific file: #21166 (comment)

This change therefore reverts the use of a native-specific file, combining its changes into the shared index file.

* Remove layout constant, for clarity

As the layout constant doesn't currently have any values other than "squared", it's removed with this commit.
@SiobhyB SiobhyB closed this Nov 22, 2021
@SiobhyB SiobhyB deleted the rnmobile/add/tiled-gallery-context branch November 22, 2021 12:10
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 22, 2021
@SiobhyB SiobhyB mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiobhyB @matticbot