Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Install: Bump MC stat on success or fail. #21893

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Plugin Install: Bump MC stat on success or fail. #21893

merged 4 commits into from
Nov 29, 2021

Conversation

dereksmart
Copy link
Member

@dereksmart dereksmart commented Nov 29, 2021 •
edited
Loading

Follow-up of the feedback in #21719 (comment)

Changes proposed in this Pull Request:

This bumps an MC stat when Jetpack tries to install a plugin. This install is used in the JITM sideloading functionality. I've only added stats to install as it's most likely to fail (vs activating). We're interested to see how many sites have trouble "sideloading" plugins through this API, particularly as #21719 and #21719 are merged and will likely get activated from wpcom soon after this release.

Stat group: jetpack-install-plugin
Stat name: fail-$slug || success-$slug

Jetpack product discussion

Related discussions
p1HpG7-dzq-p2
#21719 (comment)
p1HpG7-dHF-p2

Does this pull request change what data or activity we track or use?

Yes, but it's non-identifying data. Just an incremental stat count.

Testing instructions:

You should be able to test this with our existing JITMs for WC Services and CreativeMail.

  • Activate Jetpack Contact Form
  • Navigate to /wp-admin/edit.php?post_type=feedback
  • See the JITM to install CreativeMail
  • Click it
  • Verify the stat was bumped in MC Stats.

@dereksmart dereksmart added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 29, 2021
@dereksmart dereksmart added this to the jetpack/10.4 milestone Nov 29, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

jeherve
jeherve reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add some stats to the install_and_activate_plugin method as well, to check the situations where the plugin is already installed, but not active?

projects/plugins/jetpack/_inc/lib/plugins.php Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Tracks and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 29, 2021
@dereksmart dereksmart added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 29, 2021
@dereksmart dereksmart added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 29, 2021
@dereksmart
Copy link
Member Author

@jeherve I decided to not track the cases where the plugin is already installed/active. What we're mostly interested in with this stat is determining how many sites error when attempting to install a plugin this way. Using the MC Stats package now though!

@dereksmart dereksmart enabled auto-merge (squash) November 29, 2021 18:07
kraftbj
kraftbj approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for the initial quick-grab of stats. This will help us determine, in a broad way, if sideloading is a relatively stable thing we could investigate further for more use.

@dereksmart dereksmart merged commit ed4b1e0 into master Nov 29, 2021
@dereksmart dereksmart deleted the update/install-plugins-mc-stats branch November 29, 2021 18:39
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 29, 2021
davidlonjon added a commit that referenced this pull request Dec 2, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
ff0aada 
* master: (22 commits)
  Update storybook monorepo to v6.4.0 (#21897)
  Refresh the site's modules and settings after successful product activation (#21886)
  Plugin Install: Bump MC stat on success or fail. (#21893)
  Nav Unification: Use correct user capability for the Inbox menu item (#21882)
  Jetpack: Extend disconnection dialog component to handle multiple steps and accept more props (#21048)
  Disable CSSTidy property shorthand optimization in the editor or headstart (#21891)
  Connection UI: Update Composer instructions in README.md (#21890)
  Partner Compatibility: Adding a unique connection screen for customers who receive a coupon from a Jetpack partner (#21813)
  Search package: move search dashboard to package - the base (#21865)
  JITM: wrap CTA below text on small viewports (#21688)
  Licensing JS Package – fix icon positioning and width (#21878)
  JITM: new JS and CSS builder (#21874)
  Support site_intent for `/me/sites` endpoint (#21880)
  Don't render Critical CSS while generating CritCSS. (#21879)
  ConnectScreen: make button full width on small screens (#21683)
  Improve the copy of the license activation banner (#21876)
  Rename Webpack-built files back from `.min.js` and remove hashes (#21748)
  Search: Migrate more helper classes to package (#21751)
  Search: migrate/add search rest API (#21584)
  Add initial state to the connection package (#21864)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve left review comments

@kraftbj kraftbj kraftbj approved these changes

Assignees

@dereksmart dereksmart

Labels
[Feature] Tracks [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dereksmart @kraftbj @jeherve