-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add missing nyc
dep when creating JS packages
#22471
Conversation
When creating a JS package, the CLI is pre-filling the test-coverage script with a call to `nyc`. But it wasn't also pre-adding a dependency on nyc, resulting in coverage not working for several packages. Also, add the missing dep to those packages.
Caution: This PR has changes that must be merged to WordPress.com |
I spotted this while looking into why the coverage job has started hitting its time limit. This'll probably actually make that problem slightly worse, but it needs to be fixed. |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
Great news! One last step: head over to your WordPress.com diff, D73664-code, and commit it. Thank you! |
r238858-wpcom |
Changes proposed in this Pull Request:
When creating a JS package, the CLI is pre-filling the test-coverage
script with a call to
nyc
. But it wasn't also pre-adding a dependencyon nyc, resulting in coverage not working for several packages.
Also, add the missing dep to those packages.
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions: