Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: check user connectivity before hitting wpcom side #22478

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

retrofox
Copy link
Contributor

Fixes #

Changes proposed in this Pull Request:

  • My Jetpack: check user connectivity before hitting wpcom side

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to My Jetpack dashboard
  • With a user connected, confirm no issues in there
  • Disconnect the user

Without these changes,

  • App got broken. White screen.

  • Confirm you get an error in the client.

  • Check the site/purchases endpoint. Get an error without error status:

** With these changes**

  • Confirm you see the error in the dev console

  • App is not broken. You still see the products list and My Plan section

  • You'd like to take a look at the network tab, too.

@retrofox retrofox added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Size] S [Package] My Jetpack labels Jan 25, 2022
@retrofox retrofox added this to the My Jetpack MVP milestone Jan 25, 2022
@retrofox retrofox requested review from leogermani and a team January 25, 2022 10:27
@retrofox retrofox self-assigned this Jan 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure about the error message: You are not connected to Jetpack as the check we're doing is for the site-level connection. Something like This site is not connected may be better but this can be part of another PR.

@retrofox retrofox merged commit 3dd572e into master Jan 25, 2022
@retrofox retrofox deleted the update/my-jetpack-check-connectivity-when-requesting branch January 25, 2022 13:15
@retrofox
Copy link
Contributor Author

LGTM. Not sure about the error message: You are not connected to Jetpack as the check we're doing is for the site-level connection. Something like This site is not connected may be better but this can be part of another PR.

Oh... too late. Going to update the text. This site is not connected sounds good to me.

@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Size] S [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants