Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Implement first approach for global notice #22484

Merged
merged 7 commits into from
Jan 26, 2022

Conversation

retrofox
Copy link
Contributor

This PR implement the first approach to deal with global notice. For this purpose:

  • Add global notice to redux store
  • Add custom hooks
  • Connect primary component to show errors in the UI

Changes proposed in this Pull Request:

  • My Jetpack: Implement first approach for global notice

Jetpack product discussion

  • My Jetpack Implement first approach for global notice

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Dispatching actions:

  • Go to My Jetpack dashboard
  • Open the dev console
  • Dispatch my-jetpack actions to show/clean global notice:
wp.data.dispatch( 'my-jetpack' ).setGlobalNotice( 'Testing an info notice', { status: 'info' } )
wp.data.dispatch( 'my-jetpack' ).setGlobalNotice( 'This is an error', { status: 'error' } )
Screen.Recording.2022-01-25.at.11.44.55.AM.mov

Disconnect the user
Once you disconnect the user, it should show a global error. It's handled by the useNoticeWatcher() hook.

@retrofox retrofox added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Size] M [Package] My Jetpack labels Jan 25, 2022
@retrofox retrofox requested a review from a team January 25, 2022 14:48
@retrofox retrofox self-assigned this Jan 25, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D73708-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox force-pushed the update/my-jetpack-implement-global-error branch 3 times, most recently from a2813a1 to 1172e57 Compare January 25, 2022 19:41
@retrofox retrofox force-pushed the update/my-jetpack-implement-global-error branch from 1172e57 to 3bd3070 Compare January 25, 2022 22:34
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well!

@retrofox retrofox merged commit 65966f6 into master Jan 26, 2022
@retrofox retrofox deleted the update/my-jetpack-implement-global-error branch January 26, 2022 16:15
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 26, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D73708-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@retrofox
Copy link
Contributor Author

Great news! One last step: head over to your WordPress.com diff, D73708-code, and commit it. Once you've done so, come back to this PR and add a comment with your changeset ID.

r238982-wpcom

@oskosk oskosk mentioned this pull request Jan 26, 2022
47 tasks
@oskosk oskosk added this to the My Jetpack MVP milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants