Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PHP test timeout to 20 min #22488

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Bump PHP test timeout to 20 min #22488

merged 1 commit into from
Jan 25, 2022

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jan 25, 2022 •
edited
Loading

Band-aids issue with PHP unit tests cancelling at 15 minutes.

Changes proposed in this Pull Request:

  • Bump to 20 min

Jetpack product discussion

p1643127805171900-slack-C01U2KGS2PQ

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Do the unit tests complete?

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Jan 25, 2022
@kraftbj kraftbj self-assigned this Jan 25, 2022
@kraftbj kraftbj requested a review from jeherve January 25, 2022 17:00
@kraftbj kraftbj enabled auto-merge (squash) January 25, 2022 17:01
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jan 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 25, 2022
@kraftbj kraftbj merged commit d59d9a1 into master Jan 25, 2022
@kraftbj kraftbj deleted the update/phpunittimeout branch January 25, 2022 17:19
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 25, 2022
anomiex
anomiex reviewed Jan 25, 2022
View reviewed changes
.github/files/generate-ci-matrix.php
@@ -58,7 +58,7 @@
'script' => 'test-php',
'php' => $php,
'wp' => 'latest',
'timeout' => 15, // 2021-01-18: Successful runs seem to take ~8 minutes for PHP 5.6 and for the 7.4 master run, ~5.5-6 for 7.x and 8.0.
'timeout' => 20, // 2022-01-25: 5.6 tests have started timing out at 15 minutes. Previously: Successful runs seem to take ~8 minutes for PHP 5.6 and for the 7.4 master run, ~5.5-6 for 7.x and 8.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the cause is 1300 new Search/Sync tests added in #19674 that added about 5 minutes to the Jetpack PHPUnit tests. See also p1643047778112500-slack-CBG1CP4EN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kraftbj @jeherve @anomiex