Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: fix search product supporting determination #22519

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Jan 27, 2022

Changes proposed in this Pull Request:

Fixes compatibility issue with old activation process.

Jetpack product discussion

p8oabR-Nm#comment-5892-p2

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Go to a fresh NJ site, connect it
  • Ensure search is not supported
  • Purchase search product
  • Ensure search dashboard is available
  • Ensure Instant Search works

@kangzj kangzj added [Status] In Progress [Feature] Search For all things related to Search Instant Search [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Jan 27, 2022
@kangzj kangzj self-assigned this Jan 27, 2022
@kangzj kangzj requested a review from a team as a code owner January 27, 2022 01:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kangzj kangzj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jan 27, 2022
@kangzj kangzj requested review from jeherve and a team January 27, 2022 03:10
@kangzj kangzj changed the title Search: fix supports search compatibility Search: fix search product supporting determination Jan 27, 2022
@jeherve jeherve added this to the jetpack/10.6 milestone Jan 27, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to test well for me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 27, 2022
@jeherve jeherve merged commit b5f3436 into master Jan 27, 2022
@jeherve jeherve deleted the fix/supports-search-compatibility branch January 27, 2022 10:55
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 27, 2022
jeherve added a commit that referenced this pull request Jan 27, 2022
@jeherve
Copy link
Member

jeherve commented Jan 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants