-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: handle redirect when no connection #22549
My Jetpack: handle redirect when no connection #22549
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
bee2f57
to
6f2dabc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well in all situations
- fully connected
- connected at a site level
- redirect after disconnect
…o the Jetpack dashboard.
6f2dabc
to
97c5799
Compare
Follow up of #22530This PR adds changes about how the app handles the redirect when it doesn't have a site and a user connected.
Relevant points:
redirect
option to theuseMyJetpackConnection()
hook. When it's true, the client will perform a redirect to the Jetpack dashboard in order to offer the user to connect to their site.<ConnectionsSection />
component.Fixes #
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions: