Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Build in dependency order, optionally with dependencies #22580

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 31, 2022

Changes proposed in this Pull Request:

When multiple projects are being built, build them in dependency order
(i.e. each project's dependencies are build before the project is).

If the new --deps option is specified, include all dependencies of the
specified projects in the build.

Jetpack product discussion

PT: p9dueE-4dJ-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • jetpack build plugins/jetpack packages/assets should build Assets first.
  • jetpack build --deps plugins/jetpack should build all the dependencies of Jetpack before building Jetpack.
  • jetpack build should ask if you want to build dependencies after asking which project you want to build.
  • jetpack build --deps and jetpack build --no-deps should both prompt for a project but avoid the extra question.

When multiple projects are being built, build them in dependency order
(i.e. each project's dependencies are build before the project is).

If the new `--deps` option is specified, include all dependencies of the
specified projects in the build.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jan 31, 2022
@anomiex anomiex self-assigned this Jan 31, 2022
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 1, 2022
@anomiex anomiex merged commit fb2c7da into master Feb 1, 2022
@anomiex anomiex deleted the add/cli-build-dependencies branch February 1, 2022 16:13
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants