Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add 'Jetpack Dashboard' background color #22597

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Feb 1, 2022

This PR adds the Jetpack Dashboard background color, along with Light and Dark ones.

Changes proposed in this Pull Request:

  • Storybook: Add 'Jetpack Dashboard' background color

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Run storybook
cd ./jetpack/projects/js-packages/storybook
> pnpm install & pnpm storybook:dev

Screen Shot 2022-02-01 at 12 41 35 PM

@retrofox retrofox added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Size] S [JS Package] Storybook labels Feb 1, 2022
@retrofox retrofox requested a review from renatoagds February 1, 2022 15:42
@retrofox retrofox self-assigned this Feb 1, 2022
@github-actions github-actions bot added the RNA label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox enabled auto-merge (squash) February 1, 2022 15:59
@retrofox retrofox force-pushed the update/storybook-add-jetpack-dashboard-bg-color branch from 46e28d8 to 9c64a86 Compare February 1, 2022 16:41
@retrofox retrofox requested a review from renatoagds February 1, 2022 16:41
renatoagds
renatoagds previously approved these changes Feb 1, 2022
Copy link
Contributor

@renatoagds renatoagds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen Shot 2022-02-01 at 14 11 08

@retrofox retrofox merged commit 0752934 into master Feb 1, 2022
@retrofox retrofox deleted the update/storybook-add-jetpack-dashboard-bg-color branch February 1, 2022 18:35
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants