Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack At-a-glance: Replace Backup upgrade banner with a coupon redeem CTA when a partner coupon is detected #22602

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

atanas-dev
Copy link
Member

@atanas-dev atanas-dev commented Feb 1, 2022

Changes proposed in this Pull Request:

  • Replace the Backup upgrade banner on the "At a glance" page with a coupon redeem CTA when a partner coupon is detected.

Jetpack product discussion

pdpAdu-1A-p2

Does this pull request change what data or activity we track or use?

Yes, in Tracks:

  • jetpack_wpa_click: Now can also be triggered with 2 different props:
    • type: "redeem_partner_coupon"
    • coupon_preset: The unique slug that determines which preset a partner coupon was generated from.
  • jetpack_wpa_aag_redeem_partner_coupon_button_view: Has been added with 2 props:
    • feature: "backups" (mirroring the jetpack_wpa_aag_upgrade_button_view event)
    • coupon_preset: The unique slug that determines which preset a partner coupon was generated from.

Examples: 2b966-pb/#plain

Testing instructions:

  • Make sure Jetpack is activated and connected, has Jetpack Free as its plan, and has no other products.
  • Visit /wp-admin/admin.php?page=jetpack#/dashboard and confirm the Backup feature section shows what is visible in screenshot 1 below.
  • Visit /wp-admin/?jetpack-partner-coupon=PARTNER_COUPON_CODE to store a partner coupon code. Please reach out to team Avalon to get a coupon code.
  • Visit /wp-admin/admin.php?page=jetpack#/dashboard and confirm the Backup feature section shows what is visible in screenshot 2 below. Clicking on the Redeem button should redirect you to checkout with your partner coupon applied.
  • Purchase a product to your test site that provides backups.
  • Visit /wp-admin/admin.php?page=jetpack#/dashboard and confirm the Backup feature section shows what is visible in screenshot 3 below.

Final results:

Screenshot 1) No backup product, no partner coupon:

Screen Shot 2022-02-01 at 19 08 35

Screenshot 2) No backup product, partner coupon available:

Screen Shot 2022-02-01 at 19 03 52

Screenshot 3) Backup product active, partner coupon status is irrelevant:

Screen Shot 2022-02-01 at 18 57 18

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 22, 2022.

@atanas-dev atanas-dev force-pushed the add/partner-coupon-variation-of-backup-banner-card branch from 282b76a to 9cec5c0 Compare February 2, 2022 19:23
Copy link
Contributor

@kallehauge kallehauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design / task didn't specifically define what was expected other than showing partner coupons in the backups card, but just mentioning out loud that this PR specifically adds support for partner coupons in the backup card and not e.g. search / scan / VideoPress etc.

The only way we could "easily" add a broader override rule would be to add partner coupon override logic in <JetpackBanner> which doesn't seems right at first glance.

conclusion: I think the way we've gone around it is 👍 since backup is our most popular product anyway and if we add a condition to only show the banner if a coupon is for backup, then we can always add wider support later

kallehauge
kallehauge previously approved these changes Feb 4, 2022
Copy link
Contributor

@kallehauge kallehauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a couple of optional tracking event name suggestions

Great work @atanas-dev 👍

@atanas-dev atanas-dev added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Feb 4, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and tests well for me. 🚢

@jeherve jeherve added this to the jetpack/10.7 milestone Feb 7, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 7, 2022
@jeherve jeherve enabled auto-merge (squash) February 7, 2022 09:48
@jeherve jeherve merged commit f150c5f into master Feb 7, 2022
@jeherve jeherve deleted the add/partner-coupon-variation-of-backup-banner-card branch February 7, 2022 09:58
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants