-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack At-a-glance: Replace Backup upgrade banner with a coupon redeem CTA when a partner coupon is detected #22602
Jetpack At-a-glance: Replace Backup upgrade banner with a coupon redeem CTA when a partner coupon is detected #22602
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
…edeem CTA when a partner coupon is detected
282b76a
to
9cec5c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design / task didn't specifically define what was expected other than showing partner coupons in the backups card, but just mentioning out loud that this PR specifically adds support for partner coupons in the backup card and not e.g. search / scan / VideoPress etc.
The only way we could "easily" add a broader override rule would be to add partner coupon override logic in <JetpackBanner>
which doesn't seems right at first glance.
conclusion: I think the way we've gone around it is 👍 since backup is our most popular product anyway and if we add a condition to only show the banner if a coupon is for backup, then we can always add wider support later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a couple of optional tracking event name suggestions
Great work @atanas-dev 👍
…n the At a Glance page
…variation-of-backup-banner-card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and tests well for me. 🚢
Changes proposed in this Pull Request:
Jetpack product discussion
pdpAdu-1A-p2
Does this pull request change what data or activity we track or use?
Yes, in Tracks:
jetpack_wpa_click
: Now can also be triggered with 2 different props:type
: "redeem_partner_coupon"coupon_preset
: The unique slug that determines which preset a partner coupon was generated from.jetpack_wpa_aag_redeem_partner_coupon_button_view
: Has been added with 2 props:feature
: "backups" (mirroring thejetpack_wpa_aag_upgrade_button_view
event)coupon_preset
: The unique slug that determines which preset a partner coupon was generated from.Examples: 2b966-pb/#plain
Testing instructions:
/wp-admin/admin.php?page=jetpack#/dashboard
and confirm the Backup feature section shows what is visible in screenshot 1 below./wp-admin/?jetpack-partner-coupon=PARTNER_COUPON_CODE
to store a partner coupon code. Please reach out to team Avalon to get a coupon code./wp-admin/admin.php?page=jetpack#/dashboard
and confirm the Backup feature section shows what is visible in screenshot 2 below. Clicking on the Redeem button should redirect you to checkout with your partner coupon applied./wp-admin/admin.php?page=jetpack#/dashboard
and confirm the Backup feature section shows what is visible in screenshot 3 below.Final results:
Screenshot 1) No backup product, no partner coupon:
Screenshot 2) No backup product, partner coupon available:
Screenshot 3) Backup product active, partner coupon status is irrelevant: