-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress: Change the default for the "usesAverageColor" setting to True #22608
VideoPress: Change the default for the "usesAverageColor" setting to True #22608
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well! Thanks for dealing with the deprecation stuff 😵💫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this tests well for me. 🚢
…efault-progress-colour-option
Great news! One last step: head over to your WordPress.com diff, D74216-code, and commit it. Thank you! |
Changeset ID: 239672 |
Fixes # 1104-gh-Automattic/greenhouse
This PR changes the default value for the "usesAverageColor" setting (appears as "Match video" under the Progress Bar Colors menu) to
true
fromfalse
since now that its been tested manually for a while we want to make the default behaviour.Changes proposed in this Pull Request:
usesAverageColor
changed totrue
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Nope
Testing instructions:
jetpack build plugins/jetpack
/video
block and ensure the Progress Bar Colors -> Match video setting is disabled/video
block and turn on the Progress Bar Colors -> Match video settingjetpack build plugins/jetpack
/video
block, the Progress Bar Colors -> Match video setting should be on be default