-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Adding Connection Screen #22609
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
Related with #22291
Changes proposed in this Pull Request:
ConnectionScreen
component.connection
route.Does this pull request change what data or activity we track or use?
No.
Testing instructions:
MyJetpackScreen
componentLink
component fromreact-router-dom
any place, and set theto
for/connection
route.My Jetpack
(jetpack build packages/my-jetpack
).Dashboard
wpcom
account.My Jetpack
.Link
.ConnectionScreen
screen.Connect your user account
, it should start connection flow.Some points in the current screen are different from
Figma
, basic these points:Go back
insteadX
button, which aligns better with products flow (we can discuss it later).Connect
button isblue
insteadblack
.And more! See all Jetpack features
list item.Most of them will be implemented in the upcoming PRs.
Demo
connection-screen.mp4