-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Fire Tracks event when clicking CTA button on product Interstitial page #22672
My Jetpack: Fire Tracks event when clicking CTA button on product Interstitial page #22672
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
return ( | ||
<Container className={ styles.container } horizontalSpacing={ 0 } horizontalGap={ 0 }> | ||
<Col sm={ 4 } md={ 4 } lg={ 5 }> | ||
<ProductDetail slug={ slug } /> | ||
<ProductDetail slug={ slug } trackButtonClick={ trackProductClick } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the event should be named onAdd()
, or something like that. If you agree, we can rename it in a follow-up PR
<ProductDetail slug={ slug } trackButtonClick={ trackProductClick } /> | |
<ProductDetail slug={ slug } onAdd={ trackProductClick } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds tracking for click on product interstitial pages CTA buttons
Changes proposed in this Pull Request:
jetpack_myjetpack_product_interstitial_add_link_click
.Jetpack product discussion
Does this pull request change what data or activity we track or use?
Introduces 1 new event:
jetpack_myjetpack_product_interstitial_add_link_click
fired when the user clicks the interstitial page add buttonTesting instructions:
JETPACK_ENABLE_MY_JETPACK
constant set totrue
.localStorage.debug='dops:analyitics*
wp-admin/admin.php?page=my-jetpack#/add-boost
.jetpack_myjetpack_product_interstitial_add_link_click